[opt](s3) auto retry when meeting 429 error #35396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41184 ms |
TPC-DS: Total hot run time: 169215 ms |
ClickBench: Total hot run time: 30.55 s |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
LGTM |
gavinchou
previously approved these changes
Jun 3, 2024
ByteYue
suggested changes
Jun 3, 2024
| bvar::LatencyRecorder s3_bytes_per_read("s3_file_reader", "bytes_per_read"); // also QPS | ||
| bvar::PerSecond<bvar::Adder<uint64_t>> s3_read_througthput("s3_file_reader", "s3_read_throughput", | ||
| &s3_bytes_read_total); | ||
| // Although we can get QPS from s3_bytes_per_read, but s3_bytes_per_read only | ||
| // record successfull request, and s3_get_request_qps will record all request. | ||
| bvar::PerSecond<bvar::Adder<uint64_t>> s3_get_request_qps("s3_file_reader", "s3_get_request", |
There was a problem hiding this comment.
s3_bvar::s3_get_latency can get qps/P99 latency altogether. It seems no need to add this bvar
There was a problem hiding this comment.
s3_get_latency can only save "success" request.
s3_get_request_qps saves both "success" and "failed request"
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39925 ms |
TPC-DS: Total hot run time: 175217 ms |
ClickBench: Total hot run time: 31.11 s |
ByteYue
reviewed
Jun 24, 2024
| while (retry_count <= max_retries) { | ||
| s3_file_reader_read_counter << 1; | ||
| // clang-format off | ||
| auto resp = client->get_object( { .bucket = _bucket, .key = _key, }, |
There was a problem hiding this comment.
Suggested change
| auto resp = client->get_object( { .bucket = _bucket, .key = _key, }, | |
| { | |
| SCOPED_BVAR_LATENCY(s3_bvar::s3_get_latency); | |
| auto resp = client->get_object( { .bucket = _bucket, .key = _key, }, | |
| } |
ByteYue
approved these changes
Jun 25, 2024
AshinGau
approved these changes
Jun 27, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
gavinchou
approved these changes
Jun 27, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sometime the s3 sdk will return error like: ``` QpsLimitExceeded Unable to parse ExceptionName: QpsLimitExceeded Message: Please reduce your request rate. code=429 type=100, request_id=66516C288EC49 ``` We should slowdown the request rate by sleeping for a while. - Add 2 new BE config - `s3_read_base_wait_time_ms` and `s3_read_max_wait_time_ms` When meet s3 429 error, the "get" request will sleep `s3_read_base_wait_time_ms (*1, *2, *3, *4)` ms get try again. The max sleep time is s3_read_max_wait_time_ms and the max retry time is max_s3_client_retry - Add more metrics for s3 file reader - `s3_file_reader_too_many_request`: counter of 429 error. - `s3_file_reader_s3_get_request`: the QPS of s3 get request. - `TotalGetRequest`: Get request counter in profile - `TooManyRequestErr`: 429 error counter in profile - `TooManyRequestSleepTime`: Sum of sleep time after 429 error in profile - `TotalBytesRead`: Total bytes read from s3 in profile 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Sometime the s3 sdk will return error like:
We should slowdown the request rate by sleeping for a while.
Add 2 new BE config
s3_read_base_wait_time_msands3_read_max_wait_time_msWhen meet s3 429 error, the "get" request will
sleep
s3_read_base_wait_time_ms (*1, *2, *3, *4)ms get try again.The max sleep time is s3_read_max_wait_time_ms
and the max retry time is max_s3_client_retry
Add more metrics for s3 file reader
s3_file_reader_too_many_request: counter of 429 error.s3_file_reader_s3_get_request: the QPS of s3 get request.TotalGetRequest: Get request counter in profileTooManyRequestErr: 429 error counter in profileTooManyRequestSleepTime: Sum of sleep time after 429 error in profileTotalBytesRead: Total bytes read from s3 in profile