[fix)(colocate join) fix wrong use of colocate join #37361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39824 ms |
TPC-DS: Total hot run time: 172986 ms |
ClickBench: Total hot run time: 30.5 s |
|
run buildall |
TPC-H: Total hot run time: 39757 ms |
TPC-DS: Total hot run time: 174074 ms |
ClickBench: Total hot run time: 31.02 s |
|
run buildall |
TPC-H: Total hot run time: 40107 ms |
TPC-DS: Total hot run time: 174178 ms |
ClickBench: Total hot run time: 30.64 s |
morrySnow
approved these changes
Jul 8, 2024
| // on conditions must keep same order as distributed columns | ||
| Integer leftIndex = leftHashSpec.getExprIdToEquivalenceSet().get(((Slot) leftChild).getExprId()); | ||
| Integer rightIndex = rightHashSpec.getExprIdToEquivalenceSet().get(((Slot) rightChild).getExprId()); | ||
| if (leftIndex != rightIndex) { |
There was a problem hiding this comment.
use Objects.equals to avoid npe when leftIndex is null
There was a problem hiding this comment.
Got, I will fix it later
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
1 similar comment
|
PR approved by anyone and no changes requested. |
morrySnow
previously approved these changes
Jul 8, 2024
morrySnow
reviewed
Jul 8, 2024
Comment on lines
+318
to
+319
| Expression leftChild = ((EqualPredicate) expr).left(); | ||
| Expression rightChild = ((EqualPredicate) expr).right(); |
There was a problem hiding this comment.
not always left for left child, right for right child
There was a problem hiding this comment.
Got it, maybe it is the reason why lots of regression tests of tcpds + tpch shape failed, I will try to fix it
|
run buildall |
TPC-H: Total hot run time: 40036 ms |
TPC-DS: Total hot run time: 173973 ms |
ClickBench: Total hot run time: 30.76 s |
924060929
approved these changes
Jul 9, 2024
Yulei-Yang
approved these changes
Jul 12, 2024
cambyzju
added a commit
to cambyzju/incubator-doris
that referenced
this pull request
Jul 12, 2024
This was referenced Jul 12, 2024
morrySnow
pushed a commit
that referenced
this pull request
Jul 15, 2024
cambyzju
added a commit
to cambyzju/incubator-doris
that referenced
this pull request
Jul 16, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…ache#37729) (apache#37937) cherry-pick from master apache#37361 apache#37729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #36324