Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cloud-merge) Fix double show the property file_cache_ttl_seconds #38052

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Lchangliang
Copy link
Contributor

There has two place to append the property file_cache_ttl_seconds, cut out a place.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Lchangliang
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 18, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40092 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 41181323d3bd671ee87b27684151b40ed139fa0d, data reload: false

------ Round 1 ----------------------------------
q1	18104	5156	4355	4355
q2	2916	199	198	198
q3	11259	1206	1130	1130
q4	10679	763	777	763
q5	8413	2774	2719	2719
q6	222	138	139	138
q7	969	602	595	595
q8	9208	2129	2092	2092
q9	8777	6539	6589	6539
q10	8731	3788	3820	3788
q11	460	235	239	235
q12	399	233	221	221
q13	17792	2975	3018	2975
q14	281	238	233	233
q15	515	472	490	472
q16	505	381	374	374
q17	977	623	761	623
q18	8222	7549	7555	7549
q19	7155	1419	1348	1348
q20	706	327	340	327
q21	5103	3272	3143	3143
q22	363	275	290	275
Total cold run time: 121756 ms
Total hot run time: 40092 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4397	4233	4225	4225
q2	375	273	262	262
q3	3046	2837	2799	2799
q4	1880	1629	1642	1629
q5	5345	5338	5302	5302
q6	216	131	132	131
q7	2146	1736	1765	1736
q8	3220	3342	3325	3325
q9	8495	8421	8447	8421
q10	3904	3732	3698	3698
q11	580	497	509	497
q12	791	633	613	613
q13	16368	2970	2976	2970
q14	308	276	269	269
q15	517	486	474	474
q16	468	417	434	417
q17	1750	1466	1460	1460
q18	7731	7687	7564	7564
q19	1699	1635	1458	1458
q20	2021	1773	1799	1773
q21	10557	4766	4828	4766
q22	566	496	532	496
Total cold run time: 76380 ms
Total hot run time: 54285 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174193 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 41181323d3bd671ee87b27684151b40ed139fa0d, data reload: false

query1	927	387	370	370
query2	6449	1911	1795	1795
query3	6653	207	215	207
query4	28086	17536	17254	17254
query5	4182	495	493	493
query6	261	185	170	170
query7	4613	286	297	286
query8	239	200	194	194
query9	8372	2472	2454	2454
query10	436	271	285	271
query11	12386	10216	10183	10183
query12	138	87	85	85
query13	1645	383	380	380
query14	9688	7868	7655	7655
query15	222	178	171	171
query16	7421	335	317	317
query17	1682	572	536	536
query18	1747	287	286	286
query19	226	155	160	155
query20	97	84	87	84
query21	221	132	128	128
query22	4485	4165	4002	4002
query23	33954	33167	33324	33167
query24	12008	2850	2890	2850
query25	663	388	399	388
query26	1758	155	154	154
query27	2709	275	288	275
query28	7231	2024	2034	2024
query29	1056	650	635	635
query30	295	151	149	149
query31	990	779	755	755
query32	100	55	57	55
query33	796	325	306	306
query34	919	504	504	504
query35	702	594	597	594
query36	1093	921	922	921
query37	152	80	86	80
query38	2931	2751	2763	2751
query39	883	835	819	819
query40	287	124	127	124
query41	51	48	48	48
query42	126	104	101	101
query43	499	488	458	458
query44	1249	738	727	727
query45	193	168	163	163
query46	1103	746	730	730
query47	1863	1772	1780	1772
query48	387	297	300	297
query49	1230	426	419	419
query50	786	403	399	399
query51	6958	6811	6718	6718
query52	111	92	101	92
query53	366	296	296	296
query54	1197	449	448	448
query55	76	73	79	73
query56	288	283	268	268
query57	1186	1057	1070	1057
query58	257	244	254	244
query59	2931	2651	2847	2651
query60	300	276	287	276
query61	95	98	95	95
query62	821	655	669	655
query63	329	296	289	289
query64	10605	2199	7446	2199
query65	3193	3108	3100	3100
query66	1372	336	340	336
query67	15808	14971	15258	14971
query68	6407	552	550	550
query69	718	447	377	377
query70	1240	1135	1163	1135
query71	522	280	288	280
query72	8560	5892	5845	5845
query73	781	329	329	329
query74	6138	5690	5633	5633
query75	4843	2681	2731	2681
query76	4754	962	868	868
query77	778	313	311	311
query78	9940	9314	8977	8977
query79	8759	531	524	524
query80	956	478	481	478
query81	584	229	222	222
query82	1025	132	126	126
query83	333	171	166	166
query84	276	84	91	84
query85	1467	296	299	296
query86	445	310	321	310
query87	3393	3125	3130	3125
query88	5174	2465	2473	2465
query89	558	375	384	375
query90	2052	204	204	204
query91	129	100	135	100
query92	63	50	49	49
query93	7173	515	509	509
query94	1236	215	219	215
query95	420	320	323	320
query96	633	281	275	275
query97	3224	3036	3020	3020
query98	207	196	197	196
query99	1543	1251	1239	1239
Total cold run time: 306414 ms
Total hot run time: 174193 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 41181323d3bd671ee87b27684151b40ed139fa0d, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.03
query3	0.22	0.05	0.05
query4	1.67	0.08	0.08
query5	0.52	0.47	0.50
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.49	0.51
query10	0.54	0.54	0.53
query11	0.15	0.12	0.12
query12	0.14	0.12	0.12
query13	0.58	0.58	0.58
query14	0.75	0.78	0.77
query15	0.84	0.80	0.80
query16	0.37	0.37	0.38
query17	1.05	1.04	0.96
query18	0.23	0.22	0.22
query19	1.82	1.72	1.75
query20	0.01	0.01	0.01
query21	15.40	0.73	0.64
query22	3.94	6.96	2.04
query23	18.30	1.30	1.24
query24	2.14	0.21	0.23
query25	0.16	0.09	0.08
query26	0.29	0.21	0.21
query27	0.45	0.23	0.23
query28	13.22	1.04	1.00
query29	12.62	3.30	3.29
query30	0.25	0.06	0.06
query31	2.86	0.39	0.39
query32	3.31	0.48	0.48
query33	2.88	2.97	2.93
query34	17.22	4.43	4.36
query35	4.40	4.41	4.40
query36	0.64	0.47	0.47
query37	0.19	0.16	0.16
query38	0.15	0.14	0.14
query39	0.04	0.03	0.03
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.05	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.56 s
Total hot run time: 30.73 s

@dataroaring dataroaring merged commit 7d99ec2 into apache:master Jul 18, 2024
27 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
…38052)

There has two place to append the property `file_cache_ttl_seconds`, cut
out a place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants