Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](type)support runtime predicate for time type #38258

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[fix](type)support runtime predicate for time type #38258

merged 1 commit into from
Jul 29, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Jul 23, 2024

Proposed changes

before

mysql [test]>select timediff(a, b) as col01, count(c)  from t002 group by col01 limit 1; 
ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INTERNAL_ERROR]meet invalid type, type=27, expr=TExprNode(node_type=FUNCTION_CALL, type=TTypeDesc(types=

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@HappenLee
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40112 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6686c9bc0523aa44e80a325225afe6e9edf52cd0, data reload: false

------ Round 1 ----------------------------------
q1	17929	4602	4371	4371
q2	2821	192	192	192
q3	11220	1167	1171	1167
q4	10332	811	839	811
q5	7602	2755	2763	2755
q6	222	137	140	137
q7	963	618	611	611
q8	9602	2080	2101	2080
q9	8704	6583	6569	6569
q10	8758	3787	3789	3787
q11	453	240	232	232
q12	394	227	217	217
q13	17772	2982	2971	2971
q14	282	223	248	223
q15	511	485	488	485
q16	498	377	373	373
q17	974	651	743	651
q18	8066	7515	7437	7437
q19	6805	1340	1390	1340
q20	708	323	350	323
q21	4821	3245	3100	3100
q22	351	281	280	280
Total cold run time: 119788 ms
Total hot run time: 40112 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4347	4214	4245	4214
q2	378	268	256	256
q3	3008	2764	2773	2764
q4	1857	1617	1578	1578
q5	5302	5363	5299	5299
q6	218	130	131	130
q7	2119	1686	1713	1686
q8	3214	3361	3351	3351
q9	8442	8408	8375	8375
q10	3875	3719	3691	3691
q11	581	511	486	486
q12	771	607	577	577
q13	17389	2940	2980	2940
q14	298	272	286	272
q15	521	475	466	466
q16	471	415	428	415
q17	1766	1530	1445	1445
q18	7803	7701	7339	7339
q19	2370	1636	1583	1583
q20	2005	1789	1759	1759
q21	4927	4642	4689	4642
q22	589	494	513	494
Total cold run time: 72251 ms
Total hot run time: 53762 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172200 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6686c9bc0523aa44e80a325225afe6e9edf52cd0, data reload: false

query1	902	374	359	359
query2	6449	1991	1817	1817
query3	6656	212	217	212
query4	28212	17562	17310	17310
query5	4162	478	481	478
query6	257	195	167	167
query7	4600	296	288	288
query8	251	204	199	199
query9	8584	2426	2397	2397
query10	446	299	281	281
query11	11572	10075	10029	10029
query12	139	85	88	85
query13	1649	398	380	380
query14	10145	7766	6982	6982
query15	228	166	171	166
query16	7761	439	475	439
query17	1561	539	516	516
query18	1860	276	272	272
query19	190	146	151	146
query20	94	89	82	82
query21	207	126	131	126
query22	4271	4119	4117	4117
query23	33662	32950	32941	32941
query24	11948	2930	2845	2845
query25	647	373	367	367
query26	1795	147	146	146
query27	2827	270	275	270
query28	7523	2001	1998	1998
query29	1087	630	627	627
query30	287	151	147	147
query31	958	715	727	715
query32	98	51	54	51
query33	772	325	326	325
query34	900	472	470	470
query35	847	735	723	723
query36	1107	967	936	936
query37	176	80	88	80
query38	2870	2800	2770	2770
query39	847	808	825	808
query40	270	123	122	122
query41	46	46	46	46
query42	115	101	106	101
query43	511	479	468	468
query44	1226	722	734	722
query45	188	159	157	157
query46	1065	709	740	709
query47	1864	1755	1762	1755
query48	366	287	287	287
query49	1199	414	411	411
query50	789	398	391	391
query51	6808	6642	6640	6640
query52	99	91	92	91
query53	369	288	285	285
query54	949	447	448	447
query55	77	74	74	74
query56	285	270	277	270
query57	1183	1078	1034	1034
query58	257	245	258	245
query59	2935	2666	2752	2666
query60	306	277	281	277
query61	99	97	95	95
query62	832	685	649	649
query63	346	299	299	299
query64	10449	2190	1666	1666
query65	3164	3106	3146	3106
query66	1362	338	331	331
query67	15478	15069	15035	15035
query68	4607	558	549	549
query69	468	336	364	336
query70	1197	1163	1123	1123
query71	407	289	283	283
query72	7125	5337	5943	5337
query73	743	333	329	329
query74	6226	5728	5606	5606
query75	3453	2729	2705	2705
query76	2798	980	922	922
query77	461	332	314	314
query78	9693	9019	9964	9019
query79	2105	523	527	523
query80	982	484	479	479
query81	582	218	221	218
query82	648	133	134	133
query83	230	169	166	166
query84	242	86	87	86
query85	1968	310	296	296
query86	489	329	298	298
query87	3284	3127	3081	3081
query88	4285	2389	2385	2385
query89	486	386	391	386
query90	1834	197	198	197
query91	145	117	114	114
query92	68	53	53	53
query93	1919	519	508	508
query94	1239	311	280	280
query95	407	328	326	326
query96	603	275	274	274
query97	3161	2984	3001	2984
query98	228	205	197	197
query99	1689	1258	1247	1247
Total cold run time: 284956 ms
Total hot run time: 172200 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6686c9bc0523aa44e80a325225afe6e9edf52cd0, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.47	0.48
query6	1.14	0.72	0.74
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.56	0.50	0.48
query10	0.55	0.55	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.58
query14	0.76	0.77	0.79
query15	0.85	0.81	0.81
query16	0.36	0.36	0.36
query17	0.95	1.01	0.96
query18	0.23	0.22	0.22
query19	1.75	1.72	1.75
query20	0.02	0.01	0.01
query21	15.44	0.76	0.65
query22	4.11	6.32	2.31
query23	18.27	1.53	1.28
query24	2.11	0.24	0.22
query25	0.15	0.08	0.08
query26	0.29	0.21	0.21
query27	0.46	0.23	0.23
query28	13.18	1.02	1.00
query29	12.60	3.26	3.29
query30	0.28	0.06	0.06
query31	2.86	0.39	0.38
query32	3.27	0.47	0.46
query33	2.89	2.95	2.84
query34	17.10	4.39	4.37
query35	4.41	4.50	4.44
query36	0.65	0.46	0.48
query37	0.19	0.15	0.16
query38	0.15	0.15	0.15
query39	0.04	0.03	0.03
query40	0.16	0.12	0.13
query41	0.10	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.46 s
Total hot run time: 30.95 s

@Mryange
Copy link
Contributor Author

Mryange commented Jul 24, 2024

run external

HappenLee
HappenLee approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit 60eea39 into apache:master Jul 29, 2024
27 of 30 checks passed
Mryange added a commit to Mryange/doris that referenced this pull request Jul 29, 2024
@Mryange
[fix](type)support runtime predicate for time type (apache#38258)
465578c
@Mryange Mryange mentioned this pull request Jul 29, 2024
Merged
Mryange added a commit to Mryange/doris that referenced this pull request Jul 29, 2024
@Mryange
[fix](type)support runtime predicate for time type (apache#38258)
1121965
@Mryange Mryange mentioned this pull request Jul 29, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 31, 2024
@Mryange
[fix](type)support runtime predicate for time type (#38258) (#38465)
017dad8 
## Proposed changes
#38258
Issue Number: close #xxx

<!--Describe your changes.-->
xiaokang pushed a commit that referenced this pull request Aug 1, 2024
@Mryange
[fix](type)support runtime predicate for time type (#38258) (#38466)
0a7f8eb
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
@Mryange @dataroaring
[fix](type)support runtime predicate for time type (#38258)
73c9a6f
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
@Mryange @dataroaring
[fix](type)support runtime predicate for time type (#38258)
28c0cae
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
mongo360 pushed a commit to mongo360/doris that referenced this pull request Dec 11, 2024
@Mryange
[fix](type)support runtime predicate for time type (apache#38258) (ap…
911d9b6 
…ache#38466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.14-merged dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Mryange @doris-robot @HappenLee @BiteTheDDDDt @xiaokang @yiguolei @dataroaring