[improvement](mtmv) Support to partition prune when query rewrite by sync materialized view #38527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41617 ms |
TPC-DS: Total hot run time: 169620 ms |
ClickBench: Total hot run time: 30.18 s |
morrySnow
reviewed
Jul 31, 2024
| indexId, | ||
| PreAggStatus.unset(), | ||
| preAggStatus, |
There was a problem hiding this comment.
the preAggStatus is variable.
it's is unset when sync materialization context and is on when async materialization context
| return scanPlan; | ||
| } | ||
| if (queryStructInfo.getRelations().size() == 1 | ||
| && queryStructInfo.getRelations().get(0) instanceof LogicalOlapScan |
There was a problem hiding this comment.
refer to org.apache.doris.nereids.rules.rewrite.DeferMaterializeTopNResult, maybe relation could be LogicalDeferMaterializeOlapScan? can we collect correct struct info?
There was a problem hiding this comment.
Yeah, we can collect the LogicalDeferMaterializeOlapScan when collect the struct info
private static class RelationCollector extends DefaultPlanVisitor<Void, List<CatalogRelation>> {
@Override
public Void visit(Plan plan, List<CatalogRelation> collectedRelations) {
if (plan instanceof CatalogRelation) {
collectedRelations.add((CatalogRelation) plan);
}
return super.visit(plan, collectedRelations);
}
}
|
run buildall |
TPC-H: Total hot run time: 41922 ms |
TPC-DS: Total hot run time: 170203 ms |
ClickBench: Total hot run time: 29.95 s |
starocean999
approved these changes
Aug 6, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zddr
approved these changes
Aug 6, 2024
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 6, 2024
…sync materialized view (apache#38527) Support to partition prune when query rewrite by sync materialized view such as table def is as following: ```sql CREATE TABLE IF NOT EXISTS test_unique ( `time` DATETIME NULL COMMENT '查询时间', `app_name` VARCHAR(64) NULL COMMENT '标识', `event_id` VARCHAR(128) NULL COMMENT '标识', `decision` VARCHAR(32) NULL COMMENT '枚举值', `id` VARCHAR(35) NOT NULL COMMENT 'od', `code` VARCHAR(64) NULL COMMENT '标识', `event_type` VARCHAR(32) NULL COMMENT '事件类型' ) UNIQUE KEY(time) PARTITION BY RANGE(time) ( FROM ("2024-07-01 00:00:00") TO ("2024-07-15 00:00:00") INTERVAL 1 HOUR ) DISTRIBUTED BY HASH(time) BUCKETS 3 PROPERTIES ("replication_num" = "1"); ``` sync materialized view def is ```sql create materialized view as select app_name, event_id, time, count(*) from test_duplicate group by app_name, event_id, time; ``` if your query is following, if rewritten by sync materialized view successfully, should partition prune ```sql select app_name, event_id, time, count(*) from test_duplicate where time < '2024-07-05 01:00:00' group by app_name, time, event_id; ```
gavinchou
pushed a commit
that referenced
this pull request
Aug 7, 2024
…sync materialized view (#38527) ## Proposed changes Support to partition prune when query rewrite by sync materialized view such as table def is as following: ```sql CREATE TABLE IF NOT EXISTS test_unique ( `time` DATETIME NULL COMMENT '查询时间', `app_name` VARCHAR(64) NULL COMMENT '标识', `event_id` VARCHAR(128) NULL COMMENT '标识', `decision` VARCHAR(32) NULL COMMENT '枚举值', `id` VARCHAR(35) NOT NULL COMMENT 'od', `code` VARCHAR(64) NULL COMMENT '标识', `event_type` VARCHAR(32) NULL COMMENT '事件类型' ) UNIQUE KEY(time) PARTITION BY RANGE(time) ( FROM ("2024-07-01 00:00:00") TO ("2024-07-15 00:00:00") INTERVAL 1 HOUR ) DISTRIBUTED BY HASH(time) BUCKETS 3 PROPERTIES ("replication_num" = "1"); ``` sync materialized view def is ```sql create materialized view as select app_name, event_id, time, count(*) from test_duplicate group by app_name, event_id, time; ``` if your query is following, if rewritten by sync materialized view successfully, should partition prune ```sql select app_name, event_id, time, count(*) from test_duplicate where time < '2024-07-05 01:00:00' group by app_name, time, event_id; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support to partition prune when query rewrite by sync materialized view
such as table def is as following:
sync materialized view def is
if your query is following, if rewritten by sync materialized view successfully, should partition prune