[Performance](opt) opt the order by performance in permutation #38985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::partial_sort(res.begin(), sort_end, res.end(), | ||
| [this](size_t a, size_t b) { return data[a] < data[b]; }); | ||
| } else { | ||
| if (reverse) |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (reverse) | |
| if (reverse) { |
be/src/vec/columns/column_decimal.h:283:
- else
+ } else| if (reverse) | ||
| pdqsort(res.begin(), res.end(), | ||
| [this](size_t a, size_t b) { return data[a] > data[b]; }); | ||
| else |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| else | |
| else { |
be/src/vec/columns/column_decimal.h:285:
- [this](size_t a, size_t b) { return data[a] < data[b]; });
+ [this](size_t a, size_t b) { return data[a] < data[b]; });
+ }| limit = 0; | ||
| } | ||
| // std::partial_sort need limit << s can get performance benefit | ||
| if (limit > (s / 8.0)) limit = 0; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (limit > (s / 8.0)) limit = 0; | |
| if (limit > (s / 8.0)) { limit = 0; | |
| } |
| @@ -236,7 +236,8 @@ void ColumnVector<T>::get_permutation(bool reverse, size_t limit, int nan_direct | |||
|
|
|||
| if (s == 0) return; | |||
|
|
|||
| if (limit >= s) limit = 0; | |||
| // std::partial_sort need limit << s can get performance benefit | |||
| if (limit > (s / 8.0)) limit = 0; | |||
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (limit > (s / 8.0)) limit = 0; | |
| if (limit > (s / 8.0)) { limit = 0; | |
| } |
|
run buildall |
| std::partial_sort(res.begin(), sort_end, res.end(), | ||
| [this](size_t a, size_t b) { return data[a] < data[b]; }); | ||
| } else { | ||
| if (reverse) |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (reverse) | |
| if (reverse) { |
be/src/vec/columns/column_decimal.h:284:
- else
+ } else| if (reverse) | ||
| pdqsort(res.begin(), res.end(), | ||
| [this](size_t a, size_t b) { return data[a] > data[b]; }); | ||
| else |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| else | |
| else { |
be/src/vec/columns/column_decimal.h:286:
- [this](size_t a, size_t b) { return data[a] < data[b]; });
+ [this](size_t a, size_t b) { return data[a] < data[b]; });
+ }
|
run buildall |
|
run performance |
TPC-H: Total hot run time: 42442 ms |
TPC-DS: Total hot run time: 169462 ms |
ClickBench: Total hot run time: 29.91 s |
HappenLee
added a commit
that referenced
this pull request
Aug 7, 2024
## Proposed changes cherry pick #38985 <!--Describe your changes.-->
BiteTheDDDDt
approved these changes
Aug 7, 2024
zclllyybb
approved these changes
Aug 7, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
This was referenced Aug 8, 2024
HappenLee
added a commit
that referenced
this pull request
Aug 10, 2024
Issue Number: cherry pick #38985
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
…e#38985) ## Proposed changes Before： ``` select l_quantity from lineitem order by l_quantity limit 10000020; +--------------+ | ReturnedRows | +--------------+ | 10000020 | +--------------+ 1 row in set (2 min 24.42 sec) ``` after: ``` mysql [tpch]>select l_quantity from lineitem order by l_quantity limit 10000020; +--------------+ | ReturnedRows | +--------------+ | 10000020 | +--------------+ 1 row in set (28.42 sec) ``` <!--Describe your changes.-->
yiguolei
pushed a commit
that referenced
this pull request
Aug 24, 2024
## Proposed changes Issue Number: cherry pick #38985 <!--Describe your changes.-->
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Aug 27, 2024
…e#39092) Issue Number: cherry pick apache#38985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Before：
after: