Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) datetimev2 literal equals should compare microsecond #40121

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[fix](Nereids) datetimev2 literal equals should compare microsecond #40121

merged 1 commit into from
Aug 30, 2024

Conversation

morrySnow
Copy link
Contributor

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 38144 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0fb8688d7c26cb9eab4017effd374c6a81faa7c5, data reload: false

------ Round 1 ----------------------------------
q1	18365	4535	4375	4375
q2	2484	184	180	180
q3	11023	1101	1088	1088
q4	10233	776	652	652
q5	8021	2873	2821	2821
q6	229	138	161	138
q7	990	630	608	608
q8	9585	2075	2042	2042
q9	6987	6538	6488	6488
q10	7000	2225	2169	2169
q11	462	237	247	237
q12	405	229	225	225
q13	18044	3073	3057	3057
q14	284	240	232	232
q15	525	505	498	498
q16	579	512	515	512
q17	977	758	735	735
q18	7324	6840	6962	6840
q19	1400	1038	1130	1038
q20	674	339	339	339
q21	3953	3090	2850	2850
q22	1141	1026	1020	1020
Total cold run time: 110685 ms
Total hot run time: 38144 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4348	4265	4293	4265
q2	388	281	298	281
q3	2900	2610	2689	2610
q4	1885	1649	1619	1619
q5	5403	5419	5426	5419
q6	218	132	133	132
q7	2113	1772	1790	1772
q8	3181	3378	3356	3356
q9	8462	8417	8425	8417
q10	3440	3240	3234	3234
q11	591	503	494	494
q12	785	600	614	600
q13	10906	3052	3054	3052
q14	315	283	285	283
q15	532	477	499	477
q16	623	574	576	574
q17	1792	1504	1497	1497
q18	7833	7445	7425	7425
q19	1666	1499	1551	1499
q20	2106	1821	1850	1821
q21	5416	5245	5123	5123
q22	1099	1056	1064	1056
Total cold run time: 66002 ms
Total hot run time: 55006 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188806 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0fb8688d7c26cb9eab4017effd374c6a81faa7c5, data reload: false

query1	905	379	372	372
query2	6461	1964	1926	1926
query3	6647	221	234	221
query4	34325	23209	23196	23196
query5	4148	518	493	493
query6	255	170	160	160
query7	4581	296	290	290
query8	262	225	222	222
query9	8742	2518	2478	2478
query10	426	279	277	277
query11	17806	15034	14908	14908
query12	151	101	101	101
query13	1625	372	391	372
query14	9736	7332	7253	7253
query15	284	180	177	177
query16	7911	427	460	427
query17	1576	615	569	569
query18	2091	298	295	295
query19	327	150	147	147
query20	120	115	111	111
query21	205	109	105	105
query22	4254	4090	4114	4090
query23	34048	33725	33827	33725
query24	11150	2865	2867	2865
query25	636	418	392	392
query26	1155	162	162	162
query27	2289	284	285	284
query28	7365	2133	2111	2111
query29	826	440	429	429
query30	294	159	161	159
query31	1039	771	795	771
query32	99	62	62	62
query33	772	299	296	296
query34	941	484	506	484
query35	822	748	719	719
query36	1084	938	950	938
query37	174	101	91	91
query38	3929	3880	3825	3825
query39	1445	1389	1401	1389
query40	207	121	118	118
query41	49	49	48	48
query42	125	99	103	99
query43	510	472	470	470
query44	1284	759	756	756
query45	206	187	174	174
query46	1108	749	758	749
query47	1896	1818	1841	1818
query48	382	301	302	301
query49	1099	438	517	438
query50	809	407	408	407
query51	7264	7160	7168	7160
query52	96	89	91	89
query53	258	189	187	187
query54	922	479	464	464
query55	82	77	77	77
query56	273	257	259	257
query57	1185	1057	1067	1057
query58	235	230	224	224
query59	2959	2920	2771	2771
query60	285	262	264	262
query61	99	96	98	96
query62	811	642	695	642
query63	215	186	187	186
query64	4083	686	649	649
query65	3213	3128	3230	3128
query66	816	359	337	337
query67	15522	15291	15224	15224
query68	4546	571	576	571
query69	416	281	284	281
query70	1198	1022	1068	1022
query71	339	276	286	276
query72	6687	4000	4020	4000
query73	756	333	334	333
query74	9289	8874	8836	8836
query75	3437	2683	2729	2683
query76	2840	1085	1020	1020
query77	528	329	328	328
query78	9686	9066	10164	9066
query79	2144	541	558	541
query80	1059	498	499	498
query81	594	233	236	233
query82	843	146	144	144
query83	219	154	154	154
query84	230	82	77	77
query85	1215	297	323	297
query86	411	313	306	306
query87	4423	4300	4219	4219
query88	3065	2347	2366	2347
query89	393	282	292	282
query90	1760	195	197	195
query91	126	102	99	99
query92	69	51	53	51
query93	1202	552	548	548
query94	754	313	281	281
query95	357	272	263	263
query96	581	282	277	277
query97	3235	3059	3045	3045
query98	224	208	199	199
query99	1521	1254	1279	1254
Total cold run time: 291046 ms
Total hot run time: 188806 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0fb8688d7c26cb9eab4017effd374c6a81faa7c5, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.04
query4	1.68	0.08	0.07
query5	0.50	0.49	0.51
query6	1.12	0.74	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.48	0.47
query10	0.54	0.54	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.59	0.58
query14	2.05	2.04	2.06
query15	0.89	0.82	0.82
query16	0.35	0.35	0.38
query17	0.98	0.98	0.97
query18	0.22	0.20	0.20
query19	1.88	1.82	1.75
query20	0.01	0.01	0.01
query21	15.40	0.67	0.66
query22	4.70	7.20	1.30
query23	18.29	1.41	1.26
query24	2.19	0.23	0.22
query25	0.16	0.09	0.09
query26	0.27	0.19	0.18
query27	0.08	0.07	0.08
query28	13.23	1.02	1.00
query29	12.64	3.37	3.37
query30	0.24	0.06	0.06
query31	2.87	0.42	0.39
query32	3.24	0.51	0.48
query33	3.00	2.99	3.01
query34	17.03	4.45	4.37
query35	4.42	4.52	4.44
query36	0.66	0.48	0.48
query37	0.18	0.16	0.16
query38	0.17	0.15	0.16
query39	0.05	0.03	0.04
query40	0.17	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.05	0.06
query43	0.04	0.05	0.05
Total cold run time: 111.3 s
Total hot run time: 31.4 s

@morrySnow
Copy link
Contributor Author

run external

@morrySnow
Copy link
Contributor Author

run p0

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Aug 29, 2024
@morrySnow
[fix](Nereids) datetimev2 literal equals should compare microsecond (a…
6730e3a 
…pache#40121)

pick from master apache#40121
@morrySnow morrySnow mentioned this pull request Aug 29, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 29, 2024
@morrySnow
[fix](Nereids) datetimev2 literal equals should compare microsecond (#…
82fb747 
…40121) (#40150)

pick from master #40121
@morrySnow morrySnow merged commit 901f970 into apache:master Aug 30, 2024
27 of 29 checks passed
@morrySnow morrySnow deleted the fix_datetimev2_equals branch August 30, 2024 05:58
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Sep 2, 2024
@morrySnow
[fix](Nereids) datetimev2 literal equals should compare microsecond (a…
70acfcf 
…pache#40121)

pick from master apache#40121
@morrySnow morrySnow mentioned this pull request Sep 2, 2024
Merged
morrySnow added a commit that referenced this pull request Sep 2, 2024
@morrySnow
[fix](Nereids) datetimev2 literal equals should compare microsecond (#…
6c34de6 
…40121) (#40279)

pick from master #40121
dataroaring pushed a commit that referenced this pull request Sep 3, 2024
@morrySnow @dataroaring
[fix](Nereids) datetimev2 literal equals should compare microsecond (#…
ef8397f 
…40121)
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@924060929 924060929 924060929 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.2-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @924060929 @starocean999 @yiguolei @dataroaring