fix cleanup of tmp dir in HdfsDataSegmentPusher (#3639)

apache · Nov 1, 2016 · 616735b · 616735b
1 parent 1125c5c
commit 616735b
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/extensions-core/hdfs-storage/src/main/java/io/druid/storage/hdfs/HdfsDataSegmentPusher.java b/extensions-core/hdfs-storage/src/main/java/io/druid/storage/hdfs/HdfsDataSegmentPusher.java
@@ -115,11 +115,7 @@ public DataSegment push(File inDir, DataSegment segment) throws IOException
 
       // Create parent if it does not exist, recreation is not an error
       fs.mkdirs(outDir.getParent());
-
       if (!fs.rename(tmpFile.getParent(), outDir)) {
-        if (!fs.delete(tmpFile.getParent(), true)) {
-          log.error("Failed to delete temp directory[%s]", tmpFile.getParent());
-        }
         if (fs.exists(outDir)) {
           log.info(
               "Unable to rename temp directory[%s] to segment directory[%s]. It is already pushed by a replica task.",
@@ -134,6 +130,14 @@ public DataSegment push(File inDir, DataSegment segment) throws IOException
           ));
         }
       }
+    } finally {
+      try {
+        if (fs.exists(tmpFile.getParent()) && !fs.delete(tmpFile.getParent(), true)) {
+          log.error("Failed to delete temp directory[%s]", tmpFile.getParent());
+        }
+      } catch(IOException ex) {
+        log.error(ex, "Failed to delete temp directory[%s]", tmpFile.getParent());
+      }
     }
 
     return dataSegment;