Fix TestServerInventoryView behavioral discrepancy. (#11932)

Unlike a real one, TestServerInventoryView would call segmentRemoved any time _any_ segment was removed. It should only be called when _all_ segments have been removed.
apache · Nov 17, 2021 · d76e646 · d76e646
1 parent 7f0bede
commit d76e646
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/sql/src/test/java/org/apache/druid/sql/calcite/util/TestServerInventoryView.java b/sql/src/test/java/org/apache/druid/sql/calcite/util/TestServerInventoryView.java
@@ -187,8 +187,11 @@ public void removeSegment(DataSegment segment, ServerType serverType)
     timelineCallbackExecs.forEach(
         execAndCallback -> execAndCallback.lhs.execute(() -> {
           execAndCallback.rhs.serverSegmentRemoved(whichServer, segment);
-          // assume that all replicas have been removed and fire this one too
-          execAndCallback.rhs.segmentRemoved(segment);
+
+          // Fire segmentRemoved if all replicas have been removed.
+          if (!segments.contains(segment) && !brokerSegments.contains(segment) && !realtimeSegments.contains(segment)) {
+            execAndCallback.rhs.segmentRemoved(segment);
+          }
         })
     );
   }