Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Guava to 28.2-jre version #10290

Closed
wants to merge 1 commit into from
Closed

Upgrade Guava to 28.2-jre version #10290

wants to merge 1 commit into from

Conversation

medb
Copy link
Contributor

@medb medb commented Aug 15, 2020

Description

Upgrades Guava version to improve compatibility with Hadoop 3.2+ and other newer dependencies.


This PR has:

  • been self-reviewed.
  • added or updated version, license, or notice information in licenses.yaml
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@stale
Copy link

stale bot commented Oct 17, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@medb
Copy link
Contributor Author

medb commented Oct 17, 2020

@clintropolis PTAL

@stale
Copy link

stale bot commented Oct 17, 2020

This issue is no longer marked as stale.

@stale stale bot removed the stale label Oct 17, 2020
@clintropolis
Copy link
Member

@clintropolis PTAL

Apologies for the delay. I haven't looked into upgrading Guava in a while, but I recall that there might be compatibility issues with the currently supported Hadoop version (2.8.5) if we were to upgrade. Do you know if this is still true? Otherwise we might have to hold off until we bump the supported Hadoop version to 3+, or until it can thoroughly tested to ensure that this will not cause any issues with 2.8.x.

@medb
Copy link
Contributor Author

medb commented Oct 28, 2020

Apologies for the delay. I haven't looked into upgrading Guava in a while, but I recall that there might be compatibility issues with the currently supported Hadoop version (2.8.5) if we were to upgrade. Do you know if this is still true? Otherwise we might have to hold off until we bump the supported Hadoop version to 3+, or until it can thoroughly tested to ensure that this will not cause any issues with 2.8.x.

You are right, not all changes are compatible with Hadoop 2.x versions. I will try to separate out changes that work with existing Guava version.

Do you have any plans to update to Hadoop 3?

@stale
Copy link

stale bot commented Apr 30, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@stale stale bot added the stale label Apr 30, 2022
@medb medb closed this May 26, 2023
@medb medb deleted the guava_28 branch May 26, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants