Docs: Add multi-dimension partitioning doc; refactor native batch and separate into smaller topics. #11983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
sthetland
requested changes
Nov 24, 2021
| @@ -0,0 +1,341 @@ | |||
| --- | |||
| id: native-batch-firehose | |||
There was a problem hiding this comment.
Looks like the sidebar.json update is missing. (These new pages aren't in the left nav.)
|
|
||
| For information general information on native batch indexing and parallel task indexing, see [Native batch ingestion](./native-batch.md). | ||
|
|
||
| > Firehose input has been deprecated. For information, see [Firehose](./native-batch-firehose.md). |
There was a problem hiding this comment.
Do we need to say this here? ("Firehose" doesn't otherwise appear in this page. )
docs/ingestion/native-batch.md
Outdated
|
|
||
| When you use multi-dimension partitioning for your data, Druid is able to distribute segment sizes more evenly than with single dimension partitioning. | ||
|
|
||
| For segment pruning to be effective and translate into better query performance, you must the first of your `partitionDimensions` at query time. For example, given the following `partitionDimensions`: |
There was a problem hiding this comment.
I think a word(s) is missing here, but not sure what it should be: "...you must __ the first..."
kfaraz
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Thanks for organizing the docs better, @techdocsmith !
Just one minor comment, otherwise LGTM.
| "type": "json" | ||
| } | ||
| }, | ||
| "tuningConfig" : { |
There was a problem hiding this comment.
I think this should contain a partitionsSpec as some of these fields like maxRowsPerSegment are deprecated, as described in the tuningConfig table below.
Co-authored-by: sthetland <[email protected]>
Co-authored-by: sthetland <[email protected]>
Co-authored-by: sthetland <[email protected]>
Co-authored-by: sthetland <[email protected]>
Co-authored-by: sthetland <[email protected]>
Co-authored-by: sthetland <[email protected]>
Co-authored-by: sthetland <[email protected]>
sthetland
approved these changes
Dec 3, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for multi-dimension partitioning. cc: @kfaraz
Refactors the native batch partitioning topic as follows:
parallel-indexindexioSourceThis PR has: