Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new query laning metrics to visualize lane assignment #12111

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

isandeep41
Copy link
Contributor

@isandeep41 isandeep41 commented Jan 3, 2022

This PR aims to introduce a new metrics query/priority which will help to visualize the assigned lane if the Laning Strategy is enabled.

image-20220103155445805
The Grafana Dashboard shows the distribution of high/low lanes on a Druid cluster running Druid version 0.22.1


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@isandeep41 isandeep41 closed this Jan 5, 2022
@isandeep41 isandeep41 reopened this Jan 5, 2022
@isandeep41 isandeep41 force-pushed the query-laning-metrics-emitter branch from 46c2611 to ef94884 Compare January 19, 2022 13:38
Copy link
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Overall LGTM, thanks for your contirubtion, also I leave a few small suggestions

docs/operations/metrics.md Outdated Show resolved Hide resolved
@asdf2014 asdf2014 requested a review from jihoonson January 21, 2022 08:42
@isandeep41 isandeep41 closed this Jan 21, 2022
@isandeep41 isandeep41 reopened this Jan 21, 2022
@FrankChen021 FrankChen021 merged commit 61e1ffc into apache:master Mar 4, 2022
@jihoonson
Copy link
Contributor

@isandeep41 @FrankChen021 @asdf2014, thank you for getting this PR merged. It seems that Travis has started to fail after this PR is merged (https://app.travis-ci.com/github/apache/druid/builds/247395466). Can you please check the Travis failure? This is a blocker issue since the CI is broken.

@gianm
Copy link
Contributor

gianm commented Mar 5, 2022

I included a fix in #12307. It was a logical conflict between this patch and #12202, that as far as I can tell only affected the test case QueryableModuleTest.

@jihoonson
Copy link
Contributor

Thank you @gianm!

@FrankChen021
Copy link
Member

Thank you @gianm

@isandeep41
Copy link
Contributor Author

Thanks @gianm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants