-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new query laning metrics to visualize lane assignment #12111
add a new query laning metrics to visualize lane assignment #12111
Conversation
server/src/main/java/org/apache/druid/server/QuerySchedulerProvider.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/server/QueryScheduler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/server/QueryScheduler.java
Outdated
Show resolved
Hide resolved
46c2611
to
ef94884
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Overall LGTM, thanks for your contirubtion, also I leave a few small suggestions
server/src/main/java/org/apache/druid/server/QueryScheduler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/server/QueryScheduler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Benedict Jin <[email protected]>
Co-authored-by: Benedict Jin <[email protected]>
Co-authored-by: Benedict Jin <[email protected]>
@isandeep41 @FrankChen021 @asdf2014, thank you for getting this PR merged. It seems that Travis has started to fail after this PR is merged (https://app.travis-ci.com/github/apache/druid/builds/247395466). Can you please check the Travis failure? This is a blocker issue since the CI is broken. |
Thank you @gianm! |
Thank you @gianm |
Thanks @gianm |
This PR aims to introduce a new metrics
query/priority
which will help to visualize the assigned lane if the Laning Strategy is enabled.The Grafana Dashboard shows the distribution of
high/low
lanes on a Druid cluster running Druid version 0.22.1This PR has: