Duties in Indexing group (such as Auto Compaction) does not report metrics #12352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suneet-s
reviewed
Mar 22, 2022
| } else { | ||
| this.duties = duties; | ||
| } | ||
| //Auto add emit |
There was a problem hiding this comment.
What does this comment mean?
| if (DruidCoordinator.HISTORICAL_MANAGEMENT_DUTIES_DUTY_GROUP.equals(groupName)) { | ||
| emitStatsForHistoricalManagementDuties(cluster, stats, emitter, params); | ||
| } | ||
| if (dutyList.stream().anyMatch(duty -> duty instanceof CompactSegments)) { |
There was a problem hiding this comment.
Instead of passing dutiesList as a parameter to the constructor, I'd recommend passing in a boolean parameter, to make it clear that this duty doesn't deal with any of the other duties. Otherwise LGTM
|
Added |
suneet-s
approved these changes
Mar 23, 2022
TSFenwick
pushed a commit
to TSFenwick/druid
that referenced
this pull request
Apr 11, 2022
…trics (apache#12352) * add impl * add unit tests * fix checkstyle * address comments * fix checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duties in Indexing group (such as Auto Compaction) does not report metrics
Description
Duties emit metrics via the EmitClusterStatsAndMetrics class which is run as the last duty in the group. However, this duty is only added to the HistoricalManagementDuties group and not other groups such as IndexingServiceDuties group. This PR changes the following:
This PR has: