Add validation for invalid partitioned by granularities #12580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LakshSingla
reviewed
May 31, 2022
| @@ -159,7 +160,11 @@ public static Granularity convertSqlNodeToGranularity(SqlNode sqlNode) throws Pa | |||
| catch (IllegalArgumentException e) { | |||
| throw new ParseException(StringUtils.format("%s is an invalid period string", granularitySqlNode.toString())); | |||
| } | |||
| return new PeriodGranularity(period, null, null); | |||
| Granularity granularity = new PeriodGranularity(period, null, null); | |||
There was a problem hiding this comment.
This check shouldn't be here, because the method is merely supposed to be converting the given sqlNode to a Granularity. This check should be performed either in the Planner or the DruidSqlInsertNode IMO.
LakshSingla
reviewed
May 31, 2022
| @@ -159,7 +160,11 @@ public static Granularity convertSqlNodeToGranularity(SqlNode sqlNode) throws Pa | |||
| catch (IllegalArgumentException e) { | |||
| throw new ParseException(StringUtils.format("%s is an invalid period string", granularitySqlNode.toString())); | |||
| } | |||
| return new PeriodGranularity(period, null, null); | |||
| Granularity granularity = new PeriodGranularity(period, null, null); | |||
There was a problem hiding this comment.
This check shouldn't be here, because the method is merely supposed to be converting the given sqlNode to a Granularity. This check should be performed either in the Planner, DruidSqlInsertNode or the FTL file IMO.
9 tasks
|
@adarshsanjeev can we close this PR as #12589 already addresses this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While processing ingest queries, granularities which are not supported like 2 hours can be passed in the PARTITIONED BY clause. This PR adds a check for this during parsing.
This PR has: