Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushdown join filter with right side referencing columns #12749

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

rohangarg
Copy link
Member

Recently, support for partially conversion of join to a filter was added where if a join's right side contains duplicate values we convert the join as a filter to be pushed to left side while maintaing the join itself to support join multiplicity #12225

With that support, this change also performs a pushdown of join filter incase any of the columns from right side is referenced in the query computing join. Since, the right side columns are needed for the final output computation the join is retained as is.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants