-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specialized FixedIndexed implementations for java value types #12846
Open
clintropolis
wants to merge
1
commit into
apache:master
Choose a base branch
from
clintropolis:specialized-fixed-indexed-implementations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
150 changes: 150 additions & 0 deletions
150
processing/src/main/java/org/apache/druid/segment/data/FixedIndexedDoubleWriter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.druid.segment.data; | ||
|
||
import it.unimi.dsi.fastutil.doubles.DoubleIterator; | ||
import org.apache.druid.io.Channels; | ||
import org.apache.druid.java.util.common.io.smoosh.FileSmoosher; | ||
import org.apache.druid.segment.serde.Serializer; | ||
import org.apache.druid.segment.writeout.SegmentWriteOutMedium; | ||
import org.apache.druid.segment.writeout.WriteOutBytes; | ||
|
||
import javax.annotation.Nullable; | ||
import java.io.IOException; | ||
import java.nio.ByteBuffer; | ||
import java.nio.ByteOrder; | ||
import java.nio.channels.WritableByteChannel; | ||
|
||
/** | ||
* Specialized version of {@link FixedIndexedWriter} for writing double value types, with no support for null values, | ||
* and no verification that data is actually sorted. The resulting data can be read into either | ||
* {@link FixedIndexedDoubles} or a {@link FixedIndexed<Double>}, since the format is identical. | ||
* | ||
* Callers should be certain that the data written is in fact sorted if specifying it as such. If null values need | ||
* to be stored then the generic {@link FixedIndexedWriter} should be used instead. | ||
*/ | ||
public class FixedIndexedDoubleWriter implements Serializer | ||
{ | ||
private static final int PAGE_SIZE = 4096; | ||
private final SegmentWriteOutMedium segmentWriteOutMedium; | ||
private final ByteBuffer scratch; | ||
private int numWritten; | ||
@Nullable | ||
private WriteOutBytes valuesOut = null; | ||
|
||
private final boolean isSorted; | ||
|
||
public FixedIndexedDoubleWriter(SegmentWriteOutMedium segmentWriteOutMedium, boolean sorted) | ||
{ | ||
this.segmentWriteOutMedium = segmentWriteOutMedium; | ||
// this is a matter of faith, nothing checks | ||
this.isSorted = sorted; | ||
this.scratch = ByteBuffer.allocate(Double.BYTES).order(ByteOrder.nativeOrder()); | ||
} | ||
|
||
public void open() throws IOException | ||
{ | ||
this.valuesOut = segmentWriteOutMedium.makeWriteOutBytes(); | ||
} | ||
|
||
@Override | ||
public long getSerializedSize() | ||
{ | ||
return Byte.BYTES + Byte.BYTES + Integer.BYTES + valuesOut.size(); | ||
} | ||
|
||
public void write(double objectToWrite) throws IOException | ||
{ | ||
scratch.clear(); | ||
scratch.putDouble(objectToWrite); | ||
scratch.flip(); | ||
Channels.writeFully(valuesOut, scratch); | ||
numWritten++; | ||
} | ||
|
||
@Override | ||
public void writeTo( | ||
WritableByteChannel channel, | ||
FileSmoosher smoosher | ||
) throws IOException | ||
{ | ||
scratch.clear(); | ||
// version 0 | ||
scratch.put((byte) 0); | ||
// no flags, this thing is never sorted | ||
byte flags = 0x00; | ||
if (isSorted) { | ||
flags = (byte) (flags | FixedIndexed.IS_SORTED_MASK); | ||
} | ||
scratch.put(flags); | ||
scratch.flip(); | ||
Channels.writeFully(channel, scratch); | ||
scratch.clear(); | ||
scratch.putInt(numWritten); | ||
scratch.flip(); | ||
Channels.writeFully(channel, scratch); | ||
valuesOut.writeTo(channel); | ||
} | ||
|
||
public DoubleIterator getIterator() | ||
{ | ||
final ByteBuffer iteratorBuffer = ByteBuffer.allocate(Double.BYTES * PAGE_SIZE).order(ByteOrder.nativeOrder()); | ||
|
||
return new DoubleIterator() | ||
{ | ||
@Override | ||
public double nextDouble() | ||
{ | ||
if (pos == 0 || iteratorBuffer.position() >= iteratorBuffer.limit()) { | ||
readPage(); | ||
} | ||
final double value = iteratorBuffer.getDouble(); | ||
pos++; | ||
return value; | ||
} | ||
|
||
int pos = 0; | ||
|
||
@Override | ||
public boolean hasNext() | ||
{ | ||
return pos < numWritten; | ||
} | ||
|
||
private void readPage() | ||
{ | ||
iteratorBuffer.clear(); | ||
try { | ||
if (numWritten - pos < PAGE_SIZE) { | ||
int size = (numWritten - pos) * Double.BYTES; | ||
iteratorBuffer.limit(size); | ||
valuesOut.readFully((long) pos * Double.BYTES, iteratorBuffer); | ||
} else { | ||
valuesOut.readFully((long) pos * Double.BYTES, iteratorBuffer); | ||
} | ||
iteratorBuffer.flip(); | ||
} | ||
catch (IOException e) { | ||
throw new RuntimeException(e); | ||
} | ||
} | ||
}; | ||
} | ||
} |
199 changes: 199 additions & 0 deletions
199
processing/src/main/java/org/apache/druid/segment/data/FixedIndexedDoubles.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,199 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.druid.segment.data; | ||
|
||
import com.google.common.base.Preconditions; | ||
import it.unimi.dsi.fastutil.doubles.DoubleComparator; | ||
import it.unimi.dsi.fastutil.doubles.DoubleComparators; | ||
import it.unimi.dsi.fastutil.doubles.DoubleIterator; | ||
import org.apache.druid.common.config.NullHandling; | ||
import org.apache.druid.query.monomorphicprocessing.HotLoopCallee; | ||
import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector; | ||
|
||
import javax.annotation.Nullable; | ||
import java.nio.ByteBuffer; | ||
import java.nio.ByteOrder; | ||
import java.util.Iterator; | ||
|
||
/** | ||
* Specialized implementation for {@link FixedIndexed<Double>} which does not contain any null values, allowing it to | ||
* deal in java double value types instead of {@link Double} objects, and utilize specialized {@link ByteBuffer} methods | ||
* to more efficiently read data. | ||
*/ | ||
public final class FixedIndexedDoubles implements Indexed<Double>, HotLoopCallee | ||
{ | ||
public static FixedIndexedDoubles read(ByteBuffer bb, ByteOrder byteOrder) | ||
{ | ||
final ByteBuffer buffer = bb.asReadOnlyBuffer().order(byteOrder); | ||
final byte version = buffer.get(); | ||
Preconditions.checkState(version == 0, "Unknown version [%s]", version); | ||
final byte flags = buffer.get(); | ||
final boolean hasNull = (flags & NullHandling.IS_NULL_BYTE) == NullHandling.IS_NULL_BYTE ? true : false; | ||
final boolean isSorted = (flags & FixedIndexed.IS_SORTED_MASK) == FixedIndexed.IS_SORTED_MASK ? true : false; | ||
Preconditions.checkState(!hasNull, "Cannot use FixedIndexedInts for FixedIndex with null values"); | ||
Preconditions.checkState(!(hasNull && !isSorted), "cannot have null values if not sorted"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pretty sure that this precondition will always be true if the precondition of |
||
final int size = buffer.getInt() + (hasNull ? 1 : 0); | ||
final int valuesOffset = buffer.position(); | ||
final FixedIndexedDoubles fixedIndexed = new FixedIndexedDoubles( | ||
buffer, | ||
isSorted, | ||
size, | ||
valuesOffset | ||
); | ||
bb.position(buffer.position() + (Double.BYTES * size)); | ||
return fixedIndexed; | ||
} | ||
|
||
private final ByteBuffer buffer; | ||
private final int size; | ||
private final int valuesOffset; | ||
private final boolean isSorted; | ||
private final DoubleComparator comparator; | ||
|
||
private FixedIndexedDoubles( | ||
ByteBuffer buffer, | ||
boolean isSorted, | ||
int size, | ||
int valuesOffset | ||
) | ||
{ | ||
this.buffer = buffer; | ||
this.size = size; | ||
this.valuesOffset = valuesOffset; | ||
this.isSorted = isSorted; | ||
this.comparator = DoubleComparators.NATURAL_COMPARATOR; | ||
} | ||
|
||
@Override | ||
public int size() | ||
{ | ||
return size; | ||
} | ||
|
||
@Nullable | ||
@Override | ||
public Double get(int index) | ||
{ | ||
return getDouble(index); | ||
} | ||
|
||
@Override | ||
public int indexOf(@Nullable Double value) | ||
{ | ||
if (value == null) { | ||
return -1; | ||
} | ||
return indexOf(value.doubleValue()); | ||
} | ||
|
||
public double getDouble(int index) | ||
{ | ||
return buffer.getDouble(valuesOffset + (index * Double.BYTES)); | ||
} | ||
|
||
public int indexOf(double value) | ||
{ | ||
if (!isSorted) { | ||
throw new UnsupportedOperationException("Reverse lookup not allowed."); | ||
} | ||
int minIndex = 0; | ||
int maxIndex = size - 1; | ||
while (minIndex <= maxIndex) { | ||
int currIndex = (minIndex + maxIndex) >>> 1; | ||
|
||
double currValue = getDouble(currIndex); | ||
int comparison = comparator.compare(currValue, value); | ||
if (comparison == 0) { | ||
return currIndex; | ||
} | ||
|
||
if (comparison < 0) { | ||
minIndex = currIndex + 1; | ||
} else { | ||
maxIndex = currIndex - 1; | ||
} | ||
} | ||
|
||
return -(minIndex + 1); | ||
} | ||
|
||
public DoubleIterator doubleIterator() | ||
{ | ||
final ByteBuffer copy = buffer.asReadOnlyBuffer().order(buffer.order()); | ||
copy.position(valuesOffset); | ||
copy.limit(valuesOffset + (size * Double.BYTES)); | ||
return new DoubleIterator() | ||
{ | ||
@Override | ||
public double nextDouble() | ||
{ | ||
return copy.getDouble(); | ||
} | ||
|
||
@Override | ||
public boolean hasNext() | ||
{ | ||
return copy.hasRemaining(); | ||
} | ||
}; | ||
} | ||
|
||
@Override | ||
public Iterator<Double> iterator() | ||
{ | ||
final DoubleIterator doubleIterator = doubleIterator(); | ||
return new Iterator<Double>() | ||
{ | ||
@Override | ||
public boolean hasNext() | ||
{ | ||
return doubleIterator.hasNext(); | ||
} | ||
|
||
@Override | ||
public Double next() | ||
{ | ||
return doubleIterator.nextDouble(); | ||
} | ||
}; | ||
} | ||
|
||
@Override | ||
public void inspectRuntimeShape(RuntimeShapeInspector inspector) | ||
{ | ||
inspector.visit("buffer", buffer); | ||
inspector.visit("comparator", comparator); | ||
} | ||
|
||
@Override | ||
public String toString() | ||
{ | ||
StringBuilder sb = new StringBuilder("FixedIndexedDoubles["); | ||
if (size() > 0) { | ||
for (int i = 0; i < size(); i++) { | ||
double value = getDouble(i); | ||
sb.append(value).append(',').append(' '); | ||
} | ||
sb.setLength(sb.length() - 2); | ||
} | ||
sb.append(']'); | ||
return sb.toString(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to know if it's sorted at this level? If we are being told that it is supposed to be sorted, then I think that we should verify that it's sorted. We can do that relatively easily by just having the most-recent value, checking that the next one is greater and then storing that.
Or, if we are trusting something external from us to know that it is already sorted, then we shouldn't even bother asking it to tell us if we are sorted or not and instead just expect the external code to do the right thing.