Some improvements about Docker #13059

FrankChen021 · 2022-09-08T18:19:13Z

These some improvements about Docker, including:

Update to run with JRE 11 by default
Update to use gcr.io/distroless/java11-debian11 image as base by default. This image is currently supported image for Java 11.
Enable docker buildkit cache to speed up building
Download bash-static to the image so that scripts that require bash can be executed(Fixes Ingestion task can't be launched in docker #13057 )
bump builder image from 3.8.4-jdk-11-slim to the latest 3.8.6-jdk-11-slim
switch busybox from amd64/busybox:1.30.0-glibc to busybox:1.35.0-glibc
Support to build arm64-based image

This PR has:

been self-reviewed.
- using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
added documentation for new or modified features or behaviors.
added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
added or updated version, license, or notice information in licenses.yaml
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
added integration tests.
been tested in a test Druid cluster.

FrankChen021 · 2022-09-09T15:51:32Z

After switching to JRE 11, we need to use run-druid in the druid.sh to start Druid services because that script contains some --add-opens VM options for JRE11 and JRE 17.
Making as draft temporarily till this change is done.

xvrl · 2022-09-09T16:11:39Z

distribution/docker/Dockerfile

+RUN wget https://github.com/robxu9/bash-static/releases/download/5.1.016-1.2.3/bash-linux-x86_64 -O /bin/bash \
+ && chmod 755 /bin/bash


how much work would it be to fix the script to not use bash specific constructs?
If we are going to install bash or other things, maybe it would make sense to switch to a openjdk debian-slim image that already includes it

I also agree with you that we switch to another base image. There're two reasons:

Installing bash in this way makes it hard to support ARM64 in the future

gcr.io/distroless image can't be directly accessed in mainland Chain due to network restriction, developers in China has to use some proxy servers to download this base image.

But distroless has some advantages such as smaller size, more security.
So currently I don't have an opinion on which we should use.

how do others feel about switching base images? I agree installing bash is not multi-arch friendly, plus we do run tests against ARM64 today, so it would be nice to also do that for docker. cc @gianm

It's better to have ARM64 supported. There are some feedback that ask for ARM64 images(see #11820), and someone made it by themselves.

To support ARM64, we need be able to build and run on ARM64 based machines.
Current Dockerfile uses amd64 busybox which blocks build image to run on ARM64 machines. It's easy to solve.

Another problem is even we solve that, we still can't build the image on Mac M1. Current the web-console dependency still prevents us from doing this, see #13012

we still can't build the image on Mac M1

We can tackle building on arm and providing arm docker images separately. It should be possible to cross-compile the console until the node.js issue is resolved. That means building on M1 would be slower due to emulation, but I think that's better than not building at all.

Current Dockerfile uses amd64 busybox

it looks like you solved that problem by pointing to a multi-arch build of busybox.

I think the only issue left to solve is whether we want to switch to debian-slim, or if we want to add the logic to download the right arch binary for bash-static. The latter one might be simpler for now and we can do that by adding an if statement checking the value of $TARGETARCH (see https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope) to pick the right bash-static binary.

@gianm What's your opinion on changing the base image from distroless to debian-11?

@xvrl Actually I tried to build image on my Mac M1 by adding --platform=linux/amd64 to the docker build command several days ago, and I didn't make it. It takes more than 20 minutes and it seems it's stuck at building the source.

@xvrl Let's download the bash-static based on the target arch in this PR.

distribution/docker/README.md

distribution/docker/Dockerfile

Co-authored-by: Xavier Léauté <[email protected]>

FrankChen021 · 2022-09-14T02:36:56Z

I have built and run the image on my intel MacBook and M1 MacBook, both are OK.

distribution/docker/Dockerfile

xvrl

LGTM, just one minor typo

Co-authored-by: Xavier Léauté <[email protected]>

FrankChen021 · 2022-09-15T06:07:40Z

@gianm Do you have any comments on these changes? If no, I will merge it once the CI finishes.

xvrl · 2022-09-15T17:30:03Z

@FrankChen021 you can go ahead and merge this, I don't think there is anything controversial about it. Adding bash-static is already backported as part of #13063. The biggest change is the switch to JDK 11, so we should probably mention that fact in the PR description and also make sure we add it to the release notes.

FrankChen021 · 2022-09-16T01:25:39Z

Thank you @xvrl very much for you helpful review.

FrankChen021 added 5 commits September 5, 2022 23:43

Improve Dockerfile

7bb66d8

Update readme

337d9b5

Download bash to docker image

6713f52

Use gcr.io/distroless/java11

a9c0131

Update

9015810

FrankChen021 added the Docker https://hub.docker.com/r/apache/druid label Sep 8, 2022

FrankChen021 requested review from xvrl and gianm September 8, 2022 18:19

kfaraz mentioned this pull request Sep 9, 2022

Install bash-static in docker image #13063

Merged

9 tasks

FrankChen021 marked this pull request as draft September 9, 2022 15:51

xvrl reviewed Sep 9, 2022

View reviewed changes

distribution/docker/README.md Show resolved Hide resolved

FrankChen021 added 2 commits September 10, 2022 17:05

Update command in K8S-related scripts to use buildkit

155e321

Switch busybox from amd64/busybox to busybox

01ffd29

FrankChen021 added the WIP label Sep 10, 2022

FrankChen021 added 2 commits September 10, 2022 18:13

Use run-java to start java process

c446cc8

Add note

e88dad2

FrankChen021 marked this pull request as ready for review September 10, 2022 10:15

FrankChen021 removed the WIP label Sep 10, 2022

xvrl reviewed Sep 12, 2022

View reviewed changes

distribution/docker/Dockerfile Outdated Show resolved Hide resolved

FrankChen021 added 2 commits September 13, 2022 22:41

Download bash-static based on the target architecture

36e433b

Support for ARM64

9da8dad

xvrl reviewed Sep 13, 2022

View reviewed changes

distribution/docker/Dockerfile Outdated Show resolved Hide resolved

xvrl reviewed Sep 13, 2022

View reviewed changes

distribution/docker/Dockerfile Outdated Show resolved Hide resolved

FrankChen021 and others added 2 commits September 14, 2022 10:22

Update distribution/docker/Dockerfile

bcf9d27

Co-authored-by: Xavier Léauté <[email protected]>

Resolve comments

88ef9d6

Merge branch 'master' into docker

130cc15

FrankChen021 requested a review from xvrl September 14, 2022 12:55

xvrl reviewed Sep 14, 2022

View reviewed changes

distribution/docker/Dockerfile Outdated Show resolved Hide resolved

xvrl approved these changes Sep 14, 2022

View reviewed changes

Update distribution/docker/Dockerfile

ec31831

Co-authored-by: Xavier Léauté <[email protected]>

xvrl added the Release Notes label Sep 15, 2022

FrankChen021 merged commit b8dd822 into apache:master Sep 16, 2022

FrankChen021 deleted the docker branch September 16, 2022 04:03

kfaraz added this to the 25.0 milestone Nov 22, 2022

This was referenced Dec 18, 2022

[Draft] 25.0.0 Release Notes #13592

Closed

Add SegmentAllocationQueue to batch allocation actions #13369

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some improvements about Docker #13059

Some improvements about Docker #13059

FrankChen021 commented Sep 8, 2022 •

edited

Loading

FrankChen021 commented Sep 9, 2022 •

edited

Loading

xvrl Sep 9, 2022

FrankChen021 Sep 9, 2022

xvrl Sep 9, 2022 •

edited

Loading

FrankChen021 Sep 10, 2022

xvrl Sep 12, 2022 •

edited

Loading

FrankChen021 Sep 13, 2022

FrankChen021 Sep 13, 2022

FrankChen021 Sep 13, 2022

FrankChen021 commented Sep 14, 2022

xvrl left a comment

FrankChen021 commented Sep 15, 2022

xvrl commented Sep 15, 2022

FrankChen021 commented Sep 16, 2022

		RUN wget https://github.com/robxu9/bash-static/releases/download/5.1.016-1.2.3/bash-linux-x86_64 -O /bin/bash \
		&& chmod 755 /bin/bash

Some improvements about Docker #13059

Some improvements about Docker #13059

Conversation

FrankChen021 commented Sep 8, 2022 • edited Loading

FrankChen021 commented Sep 9, 2022 • edited Loading

xvrl Sep 9, 2022

Choose a reason for hiding this comment

FrankChen021 Sep 9, 2022

Choose a reason for hiding this comment

xvrl Sep 9, 2022 • edited Loading

Choose a reason for hiding this comment

FrankChen021 Sep 10, 2022

Choose a reason for hiding this comment

xvrl Sep 12, 2022 • edited Loading

Choose a reason for hiding this comment

FrankChen021 Sep 13, 2022

Choose a reason for hiding this comment

FrankChen021 Sep 13, 2022

Choose a reason for hiding this comment

FrankChen021 Sep 13, 2022

Choose a reason for hiding this comment

FrankChen021 commented Sep 14, 2022

xvrl left a comment

Choose a reason for hiding this comment

FrankChen021 commented Sep 15, 2022

xvrl commented Sep 15, 2022

FrankChen021 commented Sep 16, 2022

FrankChen021 commented Sep 8, 2022 •

edited

Loading

FrankChen021 commented Sep 9, 2022 •

edited

Loading

xvrl Sep 9, 2022 •

edited

Loading

xvrl Sep 12, 2022 •

edited

Loading