Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Calcite 1.32.0 #13153

Closed
wants to merge 7 commits into from

Conversation

liam-verta
Copy link
Contributor

@liam-verta liam-verta commented Sep 28, 2022

Fixes #XXXX.

Description

This superceeds #13103 and #13149. Calcite upgrade is quite a bit more work than just a "bump".

I have gotten this far but the sql build is now failing with the following output:

[INFO] --- javacc-maven-plugin:2.4:javacc (javacc) @ druid-sql ---
Java Compiler Compiler Version 4.0 (Parser Generator)
(type "javacc" with no arguments for help)
Reading from file /Users/liam/code/apache/druid/sql/target/generated-sources/annotations/javacc/Parser.jj . . .
Note: UNICODE_INPUT option is specified. Please make sure you create the parser/lexer using a Reader with the correct character encoding.
Warning: Lookahead adequacy checking not being performed since option LOOKAHEAD is more than 1.  Set option FORCE_LA_CHECK to true to force checking.
Error: Line 1228, Column 7: Non-terminal OrderItem has not been defined.
Error: Line 1233, Column 30: Non-terminal OrderItem has not been defined.
Error: Line 1453, Column 22: Non-terminal WhereOpt has not been defined.
Detected 3 errors and 1 warnings.

@adarshsanjeev @LakshSingla or anyone else with expertise in this area, help would be appreciated.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

sql/pom.xml Outdated Show resolved Hide resolved
@abhishekagarwal87
Copy link
Contributor

We cannot upgrade calcite without shading their guava dependencies. We can't upgrade our own guava because we have to support Hadoop 2. Even after shading, there is going to be a fair amount of work involved - #12258

@FrankChen021
Copy link
Member

@abhishekagarwal87 Maybe we can disable the dependency upgrade PR raised by the dependabot?

@abhishekagarwal87
Copy link
Contributor

@FrankChen021 - Thanks for the tip. I will do that.

@liam-verta
Copy link
Contributor Author

Closing duplicated effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants