-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Changes for coordinator improvements #14590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions.
|
||
The `smartSegmentLoading` mode of the Coordinator makes configuring it for segment loading and balancing much easier. | ||
In this mode, the Coordinator does not require the user to provide values of the following parameters and computes them automatically instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this mode, the Coordinator does not require the user to provide values of the following parameters and computes them automatically instead. | |
If you enable this mode, do not provide values for the properties in the table below.``` |
Co-authored-by: Jill Osborne <[email protected]>
Thanks for the quick review, @writer-jill ! I have incorporated your feedback into this PR. |
|`replicationThrottleLimit`|The maximum number of segments that can be in the replication queue of a historical tier at any given time.|500| | ||
|`balancerComputeThreads`|Thread pool size for computing moving cost of segments in segment balancing. Consider increasing this if you have a lot of segments and moving segments starts to get stuck.|1| | ||
|`replicantLifetime`|The maximum number of Coordinator runs for which a segment can wait in the load queue of a Historical before Druid raises an alert.|15| | ||
|`replicationThrottleLimit`|The maximum number of segment replicas that can be assigned to a historical tier in a single Coordinator run. This property prevents historicals from becoming overwhelmed when loading extra replicas of segments that are already available in the cluster.|500| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Nit): The maximum number of non-primary segment replicas that can be assigned to a historical tier in a single Coordinator run. This property prevents historicals from becoming overwhelmed when loading extra replicas of segments that are already available in the tier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are trying to get rid of the primary / non-primary terminology, since replica already means a copy. We will be completely removing the other config maxNonPrimaryReplicantsToLoad
soon.
Changes: - Rephrased the description of `smartSegmentLoading` - Moved detail about value computation outside of quoted block as it is important.
Changes: - Rephrased the description of `smartSegmentLoading` - Moved detail about value computation outside of quoted block as it is important.
Changes: - Rephrased the description of `smartSegmentLoading` - Moved detail about value computation outside of quoted block as it is important. Co-authored-by: Kashif Faraz <[email protected]>
Changes for coordinator improvements done in