Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Changes for coordinator improvements #14590

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Jul 16, 2023

Changes for coordinator improvements done in

@kfaraz kfaraz added this to the 27.0 milestone Jul 16, 2023
Copy link
Contributor

@writer-jill writer-jill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions.

docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved

The `smartSegmentLoading` mode of the Coordinator makes configuring it for segment loading and balancing much easier.
In this mode, the Coordinator does not require the user to provide values of the following parameters and computes them automatically instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this mode, the Coordinator does not require the user to provide values of the following parameters and computes them automatically instead.
If you enable this mode, do not provide values for the properties in the table below.```

docs/configuration/index.md Outdated Show resolved Hide resolved
docs/operations/metrics.md Outdated Show resolved Hide resolved
docs/operations/metrics.md Outdated Show resolved Hide resolved
docs/operations/metrics.md Outdated Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
@kfaraz
Copy link
Contributor Author

kfaraz commented Jul 17, 2023

Thanks for the quick review, @writer-jill ! I have incorporated your feedback into this PR.

|`replicationThrottleLimit`|The maximum number of segments that can be in the replication queue of a historical tier at any given time.|500|
|`balancerComputeThreads`|Thread pool size for computing moving cost of segments in segment balancing. Consider increasing this if you have a lot of segments and moving segments starts to get stuck.|1|
|`replicantLifetime`|The maximum number of Coordinator runs for which a segment can wait in the load queue of a Historical before Druid raises an alert.|15|
|`replicationThrottleLimit`|The maximum number of segment replicas that can be assigned to a historical tier in a single Coordinator run. This property prevents historicals from becoming overwhelmed when loading extra replicas of segments that are already available in the cluster.|500|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nit): The maximum number of non-primary segment replicas that can be assigned to a historical tier in a single Coordinator run. This property prevents historicals from becoming overwhelmed when loading extra replicas of segments that are already available in the tier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are trying to get rid of the primary / non-primary terminology, since replica already means a copy. We will be completely removing the other config maxNonPrimaryReplicantsToLoad soon.

@kfaraz kfaraz merged commit 88dc330 into apache:master Jul 18, 2023
@kfaraz kfaraz deleted the doc_coordinator branch July 18, 2023 08:52
kfaraz added a commit to kfaraz/druid that referenced this pull request Jul 18, 2023
kfaraz added a commit that referenced this pull request Jul 18, 2023
Changes:
- Rephrased the description of `smartSegmentLoading`
- Moved detail about value computation outside of quoted block as it is important.
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
Changes:
- Rephrased the description of `smartSegmentLoading`
- Moved detail about value computation outside of quoted block as it is important.
AmatyaAvadhanula pushed a commit to AmatyaAvadhanula/druid that referenced this pull request Aug 1, 2023
Changes:
- Rephrased the description of `smartSegmentLoading`
- Moved detail about value computation outside of quoted block as it is important.
AmatyaAvadhanula added a commit that referenced this pull request Aug 1, 2023
Changes:
- Rephrased the description of `smartSegmentLoading`
- Moved detail about value computation outside of quoted block as it is important.

Co-authored-by: Kashif Faraz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants