Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel loads of unused segments #14644

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Jul 24, 2023

As soon as a segment has been marked as unused, we need not continue loading it.

Changes

  • Cancel loads of unused segments in UnloadUnusedSegments
  • Add tests

Release note

Stop loading and moving segments as soon as they are marked as unused. This prevents historicals from wasting time on superfluous loads of segments that will be later unloaded anyway. Segments can be marked as unused either by a drop rule, by becoming overshadowed or through an API explicitly called by the user.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz changed the title Cancel loads of unused segments and batch delete operations Cancel loads of unused segments Jul 30, 2023
@kfaraz kfaraz merged commit 844a9c7 into apache:master Jul 31, 2023
@kfaraz kfaraz deleted the cancel_load_of_unused branch July 31, 2023 12:31
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants