-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus-emitter: add extraLabels parameter #14728
Conversation
Took a quick glance and it looks good, but need to actually review it tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to prometheus.md look good.
@TSFenwick Thanks. Whenever you can dive deeper, would be great. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks good to me. I left a few suggestions.
...theus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java
Outdated
Show resolved
Hide resolved
...theus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java
Outdated
Show resolved
Hide resolved
.../prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java
Outdated
Show resolved
Hide resolved
...theus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java
Outdated
Show resolved
Hide resolved
Thanks @abhishekrb19, I made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for this patch, @yianni!
* prometheus-emitter: add extraLabels parameter * prometheus-emitter: update readme to include the extraLabels parameter * prometheus-emitter: remove nullable and surface label name issues * remove import to make linter happy
Description
Building on previous work (#14659), this PR introduces the ability to add additional labels to Prometheus metrics, providing more flexibility for data management and identification. This change is particularly useful when managing various types of data across multiple Druid clusters.
The additional labels can be set using a new optional configuration parameter (
druid.emitter.prometheus.extraLabels
) added to the Prometheus emitter.Changes Made
druid.emitter.prometheus.extraLabels
) to the Prometheus emitter.Release note
The Prometheus emitter now supports a new optional configuration parameter,
druid.emitter.prometheus.extraLabels
. This addition offers users the flexibility to add arbitrary extra labels to their Prometheus metrics, providing more granular control in managing and identifying data across multiple Druid clusters or other dimensions.Key changed/added classes in this PR:
This PR has: