Add lifecycle hooks to KubernetesTaskRunner #14790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KubernetesTaskRunner doesn't actually register itself to be managed by @lifecycle, and nothing ever manually calls start() on it, so the cleanup job thats supposed to get started in start() never runs.
Description
Add annotations to manage the KubernetesTaskRunner with LIfecycle.
Tested this in my local cluster by making sure a job was actually cleaned up
Release note
Bugfix to druid-kubernetes-overlord-extensions
Key changed/added classes in this PR
This PR has: