Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle hooks to KubernetesTaskRunner #14790

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

georgew5656
Copy link
Contributor

The KubernetesTaskRunner doesn't actually register itself to be managed by @lifecycle, and nothing ever manually calls start() on it, so the cleanup job thats supposed to get started in start() never runs.

Description

Add annotations to manage the KubernetesTaskRunner with LIfecycle.

Tested this in my local cluster by making sure a job was actually cleaned up

Release note

Bugfix to druid-kubernetes-overlord-extensions

Key changed/added classes in this PR
  • KubernetesTaskRunner

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@YongGang YongGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@suneet-s suneet-s merged commit c8537db into apache:master Aug 10, 2023
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants