Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove segmentsToBeDropped from SegmentTransactionInsertAction #14883

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Aug 21, 2023

Description

There is no usage of the SegmentTransactionInsertAction which passes a non-null non-empty value of segmentsToBeDropped.
This is not really needed either as overshadowed segments are marked as unused by the Coordinator and need not be done in the same transaction as committing segments.

This will also help simplify the changes being made in #14407

Changes

  • Remove segmentsToBeDropped from the task action and all methods that have just been passing null
  • Remove related tests which are not needed anymore

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @kfaraz! +1 after all the checks pass

@kfaraz
Copy link
Contributor Author

kfaraz commented Aug 21, 2023

Thanks for the prompt review, @AmatyaAvadhanula !

@kfaraz kfaraz merged commit 9290605 into apache:master Aug 21, 2023
@kfaraz kfaraz deleted the cleanup_segment_insert_action branch August 21, 2023 14:39
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants