-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics for number of segments generated per task in MSQ #14980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there a way to distinguish between the metrics generated by MSQ and the native ingestion? Since we are selectively adding a few metrics, it would be nice to be able to filter by the mode of ingestion.
- We'd wanna document this in the MSQ docs and/or the metrics docs somehow
...core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestControllerContext.java
Outdated
Show resolved
Hide resolved
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java
Outdated
Show resolved
Hide resolved
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java
Outdated
Show resolved
Hide resolved
...core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestControllerContext.java
Outdated
Show resolved
Hide resolved
@LakshSingla , I suppose you could filter by the type of task that has reported that metric. |
…id/msq/exec/ControllerImpl.java Co-authored-by: Kashif Faraz <[email protected]>
yup, can use task type to distinguish. I added two examples of the metrics generated in the PR description. |
Hi @LakshSingla @kfaraz , does this change look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @LakshSingla , does this change look good to you? The main purpose for these two metrics is for alerting: when a task creates way many segments, it will make the cluster unstable, we want to be alerted in this case. |
fyi @cryptoe |
Merging the PR, cc @cryptoe if we require doc changes for the same. |
Description
Report
ingest/tombstones/count
andingest/segments/count
metrics in MSQ when finish publishing segments.Following are two examples:
Release note
Add
ingest/tombstones/count
andingest/segments/count
metrics in MSQ.Key changed/added classes in this PR
ControllerImpl
report the new metricsThis PR has: