Update S3 retry logic to account for the underlying cause in case of IOException
#15238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption. 4xx and other errors wrapped in IOException for instance aren't retriable.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| object0.setBucketName(bucket); | ||
| object0.setKey(keyPrefix + "/renames-0.gz"); | ||
| object0.getObjectMetadata().setLastModified(new Date(0)); | ||
| object0.setObjectContent(new FileInputStream(tmpFile)); |
Check warning
Code scanning / CodeQL
Potential input resource leak
|
|
||
| final File tmpFile = temporaryFolder.newFile("gzTest.gz"); | ||
|
|
||
| try (OutputStream outputStream = new GZIPOutputStream(new FileOutputStream(tmpFile))) { |
Check warning
Code scanning / CodeQL
Potential output resource leak
clintropolis
approved these changes
Oct 24, 2023
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
…`IOException` (apache#15238) * Update S3 retry logic based on the underlying cause in case of IOException. 4xx and other errors wrapped in IOException for instance aren't retriable. * Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places we wrap
AmazonS3Exceptioninside anIOExceptionand allIOExceptions by default are retried by the S3 retry logic. For example, a 403AccessDeniedSe exception code wrapped insideIOExceptionshouldn't be retried.This PR updates the s3 retry logic to account for the underlying cause if it's found.
Release note
S3 exceptions like 403 AccessDenied codes wrapped inside other exceptions, like
IOException, won't trigger unnecessary retries.Key changed/added classes in this PR
S3Utils.javaS3UtilsTest.javaS3DataSegmentPullerTest.javaThis PR has: