-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for segment/count Metric Not Emitting with Statsd-emitter #15347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
Can you update the docs for statsd and prometheus as well to indicate the correct service name.
Also, it looks like some service names are configurable - like the coordinator, overlord and broker, but historicals, peons, middle managers are hardcoded. Can the docs make reference to these configurations so that users know how to decide what service name to use.
Doc Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I mis spoke earlier. It looks like the service name for the coordinator is hard coded in CliCoordinator. Thanks for the fix!
binder.bindConstant()
.annotatedWith(Names.named("serviceName"))
.to(TieredBrokerConfig.DEFAULT_COORDINATOR_SERVICE_NAME);
Co-authored-by: Suneet Saldanha <[email protected]>
Co-authored-by: Suneet Saldanha <[email protected]>
…#15347) * fix segment/count metric in Statsd-emitter * update doc * Update docs/development/extensions-contrib/prometheus.md Co-authored-by: Suneet Saldanha <[email protected]> * Update docs/development/extensions-contrib/statsd.md Co-authored-by: Suneet Saldanha <[email protected]> --------- Co-authored-by: Suneet Saldanha <[email protected]>
Description
This pull request resolves a bug where the
segment/count
metric was not being emitted as expected when using the Statsd-emitter. The issue was traced to a discrepancy in theserviceName
used within the metric name. While the Statsd-emitter was correctly appending the serviceName to the metric name, the configured metric name within the Statsd-emitter did not include the correct serviceName. This mismatch led to a failure during the metric name comparison check, resulting in the segment/count metric not being reported. The configuration has been corrected to include the appropriate serviceName, ensuring that the segment/count metric is now emitted correctly for each service.Release note
This PR has: