Optimize mark segments as unused #15352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently marking segments as unused modifies
used
andused_status_last_updated
for every segment and this can be inefficient when kill is enabled after there are a lot of accumulated unused segments. This could potentially time out as well causing KillTask failures.This PR helps mitigate the issue by modifying only those rows which have used = true when marking them unused.
This PR has: