simplify IncrementalIndex since group-by v1 has been removed #15448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - Segment Format and Ser/De
and removed
Area - Ingestion
labels
yashdeep97
pushed a commit
to yashdeep97/druid
that referenced
this pull request
Dec 1, 2023
yashdeep97
pushed a commit
to yashdeep97/druid
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a some stuff that was only used by group-by v1, which was removed in #14866, simplifying
IncrementalIndexandOnHeapIncrementalIndeximplementations. The removed parameters are:deserializeComplexMetricswhich is always true (was false in group-by v1)concurrentEventAddwhich is always false (was true in group-by v1)sortFactswhich is always true (could be false in group-by v1)Removing the parameters allowed simplifying stuff like
FactsHolderand some other things. I've also moved the twoFactsHolderimplementations toOnHeapIncrementalIndexwhere they are actually used (no logic change here, just a simple move), assuming that any other implementations would bring their ownFactsHolderimplementation.This PR has: