Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log message when skipping auto-compaction for datasource #15460

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Nov 30, 2023

Changes

  • Change log message
    • Before: Skipping dataSource[xyz] as there is no timeline for it.
    • Now: Skipping compaction of datasource[xyz] as there is no compactible segment in its timeline.
  • Change log message
    • Before: All segments look good! Nothing to compact
    • Now: No more segments to compact in datasource[xyz].
  • Minor code cleanup for readability
  • Add some javadocs

@kfaraz kfaraz changed the title Fix message when skipping compaction Fix log message when skipping auto-compaction for datasource Nov 30, 2023
@abhishekagarwal87 abhishekagarwal87 merged commit 8ddb847 into apache:master Nov 30, 2023
83 checks passed
@kfaraz kfaraz deleted the fix_compact_skip_msg branch November 30, 2023 09:51
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
yashdeep97 pushed a commit to yashdeep97/druid that referenced this pull request Dec 1, 2023
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants