Allow different timechunk lock types to coexist in a task group #16369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
May 2, 2024
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java
Outdated
Show resolved
Hide resolved
kfaraz
approved these changes
May 2, 2024
Co-authored-by: Kashif Faraz <[email protected]>
|
Thanks for the review, @kfaraz! |
kfaraz
reviewed
May 2, 2024
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java
Outdated
Show resolved
Hide resolved
…ord/TaskLockbox.java
AmatyaAvadhanula
added a commit
to AmatyaAvadhanula/druid
that referenced
this pull request
May 2, 2024
…he#16369) Description: All the streaming ingestion tasks for a given datasource share the same lock for a given interval. Changing lock types in the supervisor can lead to segment allocation errors due to lock conflicts for the new tasks while the older tasks are still running. Fix: Allow locks of different types (EXCLUSIVE, SHARED, APPEND, REPLACE) to co-exist if they have the same interval and the same task group.
kfaraz
pushed a commit
that referenced
this pull request
May 2, 2024
…) (#16373) Description: All the streaming ingestion tasks for a given datasource share the same lock for a given interval. Changing lock types in the supervisor can lead to segment allocation errors due to lock conflicts for the new tasks while the older tasks are still running. Fix: Allow locks of different types (EXCLUSIVE, SHARED, APPEND, REPLACE) to co-exist if they have the same interval and the same task group.
IgorBerman
pushed a commit
to IgorBerman/druid
that referenced
this pull request
May 5, 2024
…he#16369) Description: All the streaming ingestion tasks for a given datasource share the same lock for a given interval. Changing lock types in the supervisor can lead to segment allocation errors due to lock conflicts for the new tasks while the older tasks are still running. Fix: Allow locks of different types (EXCLUSIVE, SHARED, APPEND, REPLACE) to co-exist if they have the same interval and the same task group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the streaming ingestion tasks for a given datasource share the same lock for a given interval. Changing lock types in the supervisor can lead to segment allocation errors due to lock conflicts for the new tasks when the older tasks are still running.
This PR allows granting of locks with different types (EXCLUSIVE, SHARED, APPEND, REPLACE) for the same interval within a task group to ensure a transition to newer set of task without failure.
This PR has: