Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for log audit manager #16927

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

jakubmatyszewski
Copy link
Contributor

Description

Add docs on druid.audit.manager.type=log implemented in Druid 29.0.0 #15480

  • added documentation for new or modified features or behaviors.

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

@@ -363,6 +363,8 @@ Coordinator and Overlord log changes to lookups, segment load/drop rules, and dy

|Property|Description|Default|
|--------|-----------|-------|
|`druid.audit.manager.type`|Allows audited events to either be logged when set to `log` or persisted in metadata store when set to `sql`.|sql|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|`druid.audit.manager.type`|Allows audited events to either be logged when set to `log` or persisted in metadata store when set to `sql`.|sql|
|`druid.audit.manager.type`|Type of audit manager used for handling audited events. Audited events are logged when set to `log` or persisted in metadata store when set to `sql`.|sql|

@@ -363,6 +363,8 @@ Coordinator and Overlord log changes to lookups, segment load/drop rules, and dy

|Property|Description|Default|
|--------|-----------|-------|
|`druid.audit.manager.type`|Allows audited events to either be logged when set to `log` or persisted in metadata store when set to `sql`.|sql|
|`druid.audit.manager.logLevel`|Set the log level of audit events and can take values DEBUG, INFO, WARN. This gets activated only if type is `log`.|INFO|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|`druid.audit.manager.logLevel`|Set the log level of audit events and can take values DEBUG, INFO, WARN. This gets activated only if type is `log`.|INFO|
|`druid.audit.manager.logLevel`|Log level of audit events with possible values DEBUG, INFO, WARN. This property is used only when `druid.audit.manager.type` is set to `log`.|INFO|

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs, @jakubmatyszewski !

@kfaraz kfaraz merged commit 82d9ff9 into apache:master Aug 20, 2024
8 checks passed
hevansDev pushed a commit to hevansDev/druid that referenced this pull request Aug 29, 2024
* Add docs for log audit manager

* Adjust descriptions
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants