abstract IncrementalIndex cursor stuff to prepare for using different "views" of the data based on the cursor build spec
#17064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y of using different "views" of the data per the cursor build spec changes: * introduce `IncrementalIndexRowSelector` interface to capture how `IncrementalIndexCursor` and `IncrementalIndexColumnSelectorFactory` read data * `IncrementalIndex` implements `IncrementalIndexRowSelector` * move `FactsHolder` interface to separate file * other minor refactorings
clintropolis
changed the title
IncrementalIndex cursor to prepare to allow for possibility of using different "views" of the data per the cursor build specIncrementalIndex cursor stuff to prepare to allow for possibility of using different "views" of the data per the cursor build spec
clintropolis
changed the title
IncrementalIndex cursor stuff to prepare to allow for possibility of using different "views" of the data per the cursor build specIncrementalIndex cursor stuff to prepare for using different "views" of the data per the cursor build spec
clintropolis
changed the title
IncrementalIndex cursor stuff to prepare for using different "views" of the data per the cursor build specIncrementalIndex cursor stuff to prepare for using different "views" of the data based on the cursor build spec
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| this.metricIndex = metricIndex; | ||
| this.rowSelector = rowSelector; | ||
| this.metricIndex = metricDesc.getIndex(); | ||
| this.classOfObject = ComplexMetrics.getSerdeForType(metricDesc.getType()).getObjectStrategy().getClazz(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
gianm
reviewed
Sep 15, 2024
| /** | ||
| * Position of {@link org.apache.druid.segment.column.ColumnHolder#TIME_COLUMN_NAME} in the dimensions list | ||
| */ | ||
| int getTimePosition(); |
There was a problem hiding this comment.
This is a weird method, because the dimension order isn't provided by other methods, so it isn't meaningful on its face. The only caller is just checking if it == 0, so it can populate a List<OrderBy>.
How about replacing this with List<OrderBy> getOrdering()?
gianm
approved these changes
Sep 15, 2024
pranavbhole
pushed a commit
to pranavbhole/druid
that referenced
this pull request
Sep 17, 2024
…nt "views" of the data based on the cursor build spec (apache#17064) * abstract `IncrementalIndex` cursor stuff to prepare to allow for possibility of using different "views" of the data based on the cursor build spec changes: * introduce `IncrementalIndexRowSelector` interface to capture how `IncrementalIndexCursor` and `IncrementalIndexColumnSelectorFactory` read data * `IncrementalIndex` implements `IncrementalIndexRowSelector` * move `FactsHolder` interface to separate file * other minor refactorings
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Oct 5, 2024
…nt "views" of the data based on the cursor build spec (apache#17064) * abstract `IncrementalIndex` cursor stuff to prepare to allow for possibility of using different "views" of the data based on the cursor build spec changes: * introduce `IncrementalIndexRowSelector` interface to capture how `IncrementalIndexCursor` and `IncrementalIndexColumnSelectorFactory` read data * `IncrementalIndex` implements `IncrementalIndexRowSelector` * move `FactsHolder` interface to separate file * other minor refactorings
Merged
abhishekagarwal87
pushed a commit
that referenced
this pull request
Oct 5, 2024
* abstract `IncrementalIndex` cursor stuff to prepare for using different "views" of the data based on the cursor build spec (#17064) * abstract `IncrementalIndex` cursor stuff to prepare to allow for possibility of using different "views" of the data based on the cursor build spec changes: * introduce `IncrementalIndexRowSelector` interface to capture how `IncrementalIndexCursor` and `IncrementalIndexColumnSelectorFactory` read data * `IncrementalIndex` implements `IncrementalIndexRowSelector` * move `FactsHolder` interface to separate file * other minor refactorings * add DataSchema.Builder to tidy stuff up a bit (#17065) * add DataSchema.Builder to tidy stuff up a bit * fixes * fixes * more style fixes * review stuff * Projections prototype (#17214)
|
This has already been backported in #17257 , so added it to the milestone. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
IncrementalIndexRowSelectorinterface to capture howIncrementalIndexCursorandIncrementalIndexColumnSelectorFactoryread dataIncrementalIndeximplementsIncrementalIndexRowSelectorFactsHolderinterface to separate file