fix issue with ScanQueryFrameProcessor cursor build not adjusting intervals #17168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
abhishekagarwal87
approved these changes
Sep 26, 2024
gianm
reviewed
Sep 26, 2024
| cursorFactory.makeCursorHolder(ScanQueryEngine.makeCursorBuildSpec(query, null)); | ||
| cursorFactory.makeCursorHolder( | ||
| ScanQueryEngine.makeCursorBuildSpec( | ||
| query.withQuerySegmentSpec(new MultipleIntervalSegmentSpec(Intervals.ONLY_ETERNITY)), |
There was a problem hiding this comment.
The old code did this too, but, it seems like it'd be incorrect if the query had an intervals filter on the __time column. I am not sure how (or if) this can actually happen, but I wonder if it could be made to happen by doing a query like this:
SELECT * FROM (SELECT * FROM "wikipedia" ORDER BY countryName LIMIT 100)
WHERE TIME_IN_INTERVAL(__time, '2020/P1D') OR TIME_IN_INTERVAL(__time, '2021/P1D')I tried doing that just now, and got a QueryNotSupported error, which seems like a different problem. But what if it was supported?
IMO, here we should add a validation here to check that query has an eternity interval, rather than overriding it to be eternity. If it was anything other than eternity, this wouldn't be correct.
kfaraz
pushed a commit
to kfaraz/druid
that referenced
this pull request
Oct 4, 2024
…ervals (apache#17168) * fix issue with ScanQueryFrameProcessor cursor build not adjusting intervals * all hail the robot overlords * style bot
kfaraz
added a commit
that referenced
this pull request
Oct 4, 2024
…g. (#17152) (#17168) (#17245) * ScanQueryFrameProcessor: Close CursorHolders as we go along. (#17152) * fix issue with ScanQueryFrameProcessor cursor build not adjusting intervals (#17168) --------- Co-authored-by: Gian Merlino <[email protected]> Co-authored-by: Clint Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactor of #16533, accidentally lost the calls to
query.withQuerySegmentSpecinScanQueryFrameProcessorhere and here