remove druid.sql.planner.serializeComplexValues config in favor of always serializing complex values #17549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways serializing complex values
…rializeComplexValues-config
clintropolis
deleted the
remove-planner-serializeComplexValues-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config option was introduced back in #6950 mainly as an escape hatch to make things backwards compatible, but setting it to false to get the old behavior is basically useless since it causes any complex type query results to just print the java class name instead of serializing the actual value into a usable form. As such, this config was never documented because the new behavior was superior, so should be totally safe to remove.