Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamAppenderator: Add sink prior to announcing it. #17649

Merged
merged 1 commit into from
Jan 22, 2025
Merged

StreamAppenderator: Add sink prior to announcing it. #17649

merged 1 commit into from
Jan 22, 2025

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Jan 21, 2025

Fixes #17633.

maytasm
maytasm approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@maytasm maytasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at the issue and the quick fix!

@gianm gianm merged commit a964220 into apache:master Jan 22, 2025
79 checks passed
@gianm gianm deleted the sink-add-before-announce branch January 22, 2025 22:53
317brian pushed a commit to 317brian/druid that referenced this pull request Jan 28, 2025
@gianm @317brian
StreamAppenderator: Add sink prior to announcing it. (apache#17649)
5da657b 
Fixes apache#17633.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maytasm maytasm maytasm approved these changes

Assignees
No one assigned
Labels
Area - Streaming Ingestion Bug
Projects
None yet
Milestone
No milestone
2 participants
@gianm @maytasm