CacheMonitor - make cache injection optional #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
xvrl
changed the title
| @@ -38,20 +39,30 @@ public CacheMonitor( | |||
| this.cache = cache; | |||
| } | |||
There was a problem hiding this comment.
is this constructor still needed?
There was a problem hiding this comment.
if someone uses it directly, yes
There was a problem hiding this comment.
not a big deal but,
i meant, is anything actually using this constructor anymore. If not, then we can remove it.
There was a problem hiding this comment.
not within Druid at least. Fine to remove, unless we want to preserve binary compatibility for extensions that might bind it
There was a problem hiding this comment.
if they are binding via guice then this shouldn't break anything.
I would remove it.
It is up to you though, I'm fine either ways :)
|
LGTM, 👍 |
allows enabling the CacheMonitor for all index tasks, even if some don't bind any cache instance.
xvrl
force-pushed
the
cachemonitor-optional-injection
branch
from
9012134 to
71376ef
Compare
|
👍 |
drcrallen
added a commit
that referenced
this pull request
Nov 17, 2015
CacheMonitor - make cache injection optional
fjy
added a commit
that referenced
this pull request
Dec 16, 2015
backport #1973 - make cache injection optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows enabling the CacheMonitor for all index tasks, even if some don't bind any cache instance (useful in combination with #1943 for realtime tasks)