Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count parameter to rules history endpoint. #1976

Merged
merged 1 commit into from Nov 17, 2015
Merged

Add count parameter to rules history endpoint. #1976

merged 1 commit into from Nov 17, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2015

Second part of feature from #1266 (second comment).

final Integer count
) throws IllegalArgumentException
{
Interval theInterval = interval == null ? null : new Interval(interval);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this line after the if statement below?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@nishantmonu51
Copy link
Member

👍

@ghost
Copy link
Author

ghost commented Nov 17, 2015

I've changed docs too.

@himanshug
Copy link
Contributor

👍 pls squash your commits.

@ghost
Copy link
Author

ghost commented Nov 17, 2015

Done.

@ghost
Copy link
Author

ghost commented Nov 17, 2015

Travis

@ghost ghost closed this Nov 17, 2015
@ghost ghost reopened this Nov 17, 2015
himanshug added a commit that referenced this pull request Nov 17, 2015
…tory

Add count parameter to rules history endpoint.
@himanshug himanshug merged commit 9118b01 into apache:master Nov 17, 2015
@ghost ghost deleted the feature/count-parameter-rules-history branch November 17, 2015 21:35
@fjy fjy modified the milestone: 0.9.0 Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants