Regex search query #2008
Merged
Regex search query #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RegexSearchQuerySpec spec = new RegexSearchQuerySpec("(upfront|total_market)"); | ||
|
|
||
| String json = jsonMapper.writeValueAsString(spec); | ||
| RegexSearchQuerySpec serdeQuery = jsonMapper.readValue(json, RegexSearchQuerySpec.class); |
There was a problem hiding this comment.
can u change to
(RegexSearchQuerySpec) jsonMapper.readValue(json, SearchQuerySpec.class);
codingwhatever
force-pushed
the
regex-search-query
branch
from
d536a9e to
807e52d
Compare
| ) | ||
| { | ||
| this.pattern = pattern; | ||
| compiled = Pattern.compile(pattern); |
There was a problem hiding this comment.
wouldn't this fail if pattern was null?
There was a problem hiding this comment.
I think we can throw an exception in case the pattern in null and document pattern as a required value.
There was a problem hiding this comment.
preconditions notnull with a hint to pattern is the typical workflow for things such as this. It helps debug on querying side.
There was a problem hiding this comment.
Ok, I added the precondition and removed all the null checks.
|
👍 @himanshug any more comments? |
|
👍 |
|
@codingwhatever pls squash your commits to make it mergeable . |
codingwhatever
force-pushed
the
regex-search-query
branch
from
134d6ed to
596b7eb
Compare
|
@himanshug I have squashed the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a SearchQuerySpec that supports searching for a regex. It uses the same regex pattern match as the RegexFilter.
I will be adding documentation shortly.