continue hadoop job for sparse intervals #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Capture<String> pathCapture = Capture.newInstance(CaptureType.ALL); | ||
| Job job = Job.getInstance(); | ||
|
|
||
| PowerMock.mockStatic(FSSpideringIterator.class); |
There was a problem hiding this comment.
is it not possible to setup the appropriate files in some temporary space on disk that reproduces the bug instead of adding PowerMock ?
There was a problem hiding this comment.
Yes that should work too - do you prefer that approach?
There was a problem hiding this comment.
yes, this test case does not look like a major reason to add another big framework for testing.
|
Thanks for the feedback @himanshug , I removed PowerMock and created local temp files for the unit test. |
|
👍 |
| Job job = Job.getInstance(); | ||
| String formatStr = "file:%s/%s;org.apache.hadoop.mapreduce.lib.input.TextInputFormat"; | ||
|
|
||
| File baseDir = Files.createTempDir(); |
There was a problem hiding this comment.
can you use the @rule TemporaryFolder for this?
There was a problem hiding this comment.
@himanshug done, thanks!
|
@dclim can you rebase from master to get the fixes for all these transient failures? |
himanshug
added a commit
that referenced
this pull request
Jan 7, 2016
continue hadoop job for sparse intervals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up the previous PR so I recreated it. Thanks Gian for the comments - I agree that having FSSpideringIterator return an empty iterator is less brittle than trying to manage an exception.
Hadoop jobs would fail with a FileNotFoundException when a granularity inputSpec was used and there wasn't data for each portion of the segment - for example, if dataGranularity was hour and the interval was 2015-11-10T00:00Z/2015-11-11T00:00Z, we would fail if our input data folder structure looked like this:
/dataSource/y=2015/m=11/d=10/H=00
/dataSource/y=2015/m=11/d=10/H=01
/dataSource/y=2015/m=11/d=10/H=03
/dataSource/y=2015/m=11/d=10/H=04
/dataSource/y=2015/m=11/d=10/H=08
/dataSource/y=2015/m=11/d=10/H=09
/dataSource/y=2015/m=11/d=10/H=15
/dataSource/y=2015/m=11/d=10/H=23
This caused segment creation to fail for sparse data which may not have an event every hour. We now ignore intervals with no data and allow the job to continue.