Adding custom mapper for json processing exception #2264
Conversation
| { | ||
| return Response.status(Response.Status.BAD_REQUEST).entity(ImmutableMap.of("Error", arg0.getMessage())).build(); | ||
| } | ||
| } |
himank
force-pushed
the
CustomExceptionMapper
branch
2 times, most recently
from
85585de to
2cb0631
Compare
|
Updated the pull request with customizing JsonMappingException instead of JsonProcessingException as the former one is more appropriate for problems related to mapping content. Before/After output is below. |
|
Thanks for the contrib @himank. Will try to review shortly |
|
@fjy Thanks :) |
|
@fjy If you get chance could you please review it, Thanks in advance. |
| public Response toResponse(JsonMappingException exception) | ||
| { | ||
| return Response.status(Response.Status.BAD_REQUEST) | ||
| .entity(ImmutableMap.of("Error", exception.getMessage())) |
There was a problem hiding this comment.
other places use "error" lower case
There was a problem hiding this comment.
also should probably be exception.getMessage() == null ? "unknown json mapping exception" : exception.getMessage() or similar
|
👍 after minor comments |
|
Thanks for the contrib @himank . Could you please fill out the CLA at http://druid.io/community/cla.html ? |
…est instead of 500
himank
force-pushed
the
CustomExceptionMapper
branch
from
2cb0631 to
1a5d4e7
Compare
|
@drcrallen Thanks for the review, updated as per your comments. Please review when you get chance :) |
|
👍 |
Adding custom mapper for json processing exception
|
@himank do you mind following the steps here? https://groups.google.com/forum/#!topic/druid-development/1Zs3Vd9LHCQ so your contribution will be counted :) |
Custom exception mapper to return bad request instead of returning 500.