Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Min/Max for Timestamp #3299

Merged
merged 4 commits into from
Nov 15, 2016
Merged

Support Min/Max for Timestamp #3299

merged 4 commits into from
Nov 15, 2016

Conversation

sirpkt
Copy link
Contributor

@sirpkt sirpkt commented Jul 28, 2016

Related with #3298.

  • Add an extension which provides two aggregator timeMax and timeMin.
  • Internally, it stores timestamp value as Long so that we can have DateTime with group by query by finalizeComputing() but only get Long value with select query.
  • To support parsing of string represented timestamp, TimestampSpec is slightly modified.
  • Incremental index is also modified to accept many different type of timestamp at ingestion time.

@fjy
Copy link
Contributor

fjy commented Aug 24, 2016

@sirpkt does this conflict with #3168?

Can we get some docs on what timeMax and timeMin do? I'm not entirely clear from reading the description

fjy
fjy reviewed Aug 27, 2016
View reviewed changes
extensions-contrib/time-min-max/src/test/resources/druid.sample.tsv
@@ -0,0 +1,1209 @@
2011-01-12T01:00:00.000Z spot automotive preferred apreferred 100.000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we gzip this file?

@sirpkt
Copy link
Contributor Author

sirpkt commented Aug 31, 2016

@fjy This is different from #3168.
Its resolution is the same as query granularity because __time is, while this patch returns exact min/max value.
#3168 returns one min/max time for the entire group of (maybe filtered) data while this patch returns separate min/max time for each row of aggregated data.

@fjy fjy added the Feature label Oct 31, 2016
@fjy fjy added this to the 0.9.3 milestone Oct 31, 2016
@fjy
Copy link
Contributor

fjy commented Oct 31, 2016

👍

@jon-wei
Copy link
Contributor

jon-wei commented Nov 7, 2016

I think this still needs docs, looks good to me aside from that

@fjy
Copy link
Contributor

fjy commented Nov 8, 2016

@sirpkt can we add docs and also an entry in the list of extensions?

@sirpkt
Copy link
Contributor Author

sirpkt commented Nov 15, 2016

@fjy I added docs.

@fjy fjy merged commit 094f5b8 into apache:master Nov 15, 2016
fundead pushed a commit to fundead/druid that referenced this pull request Dec 7, 2016
@sirpkt
Support Min/Max for Timestamp (apache#3299)
25946cc 
* Min/Max aggregator for Timestamp

* remove unused imports and method

* rebase and zip the test data

* add docs
dgolitsyn pushed a commit to metamx/druid that referenced this pull request Feb 14, 2017
@sirpkt @dgolitsyn
Support Min/Max for Timestamp (apache#3299)
95745d3 
* Min/Max aggregator for Timestamp

* remove unused imports and method

* rebase and zip the test data

* add docs
@gianm gianm mentioned this pull request Feb 28, 2017
Closed
@leventov leventov mentioned this pull request Aug 7, 2017
Closed
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Feb 25, 2022
@navis
apache#3299 Minor refactoring on value desc
d14a1ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Release Notes
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sirpkt @fjy @jon-wei @gianm