Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ReleaseException when the path is being written by multiple tasks #3494

Merged
merged 4 commits into from
Sep 22, 2016

Conversation

nishantmonu51
Copy link
Member

since #3383 is the last PR blocking 0.9.2.
Creating alternate PR for #3383 with review comments fixed.

@himanshug
Copy link
Contributor

👍 ( waiting for build )

@b-slim
Copy link
Contributor

b-slim commented Sep 22, 2016

👍

@b-slim
Copy link
Contributor

b-slim commented Sep 22, 2016

@nishantmonu51 looks like this is failing

tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.082 sec <<< FAILURE! - in io.druid.storage.hdfs.HdfsDataSegmentPusherTest
testPush(io.druid.storage.hdfs.HdfsDataSegmentPusherTest)  Time elapsed: 0.082 sec  <<< FAILURE!
java.lang.AssertionError: should throw exception
    at org.junit.Assert.fail(Assert.java:88)
    at io.druid.storage.hdfs.HdfsDataSegmentPusherTest.testPush(HdfsDataSegmentPusherTest.java:96)

@himanshug himanshug merged commit 6099d20 into apache:master Sep 22, 2016
drcrallen pushed a commit to metamx/druid that referenced this pull request Sep 27, 2016
…ks (apache#3494)

* fix ReleaseException when the path is being written by multiple task

* Do not throw IOException if another replica wins the race for segment creation

fix if check

* handle logging comments

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants