groupBy v1: Force all dimensions to strings. #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2016
|
👍 |
1 similar comment
|
👍 |
|
sure, i'll backport it |
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Nov 14, 2016
fjy
pushed a commit
that referenced
this pull request
Nov 14, 2016
fundead
pushed a commit
to fundead/druid
that referenced
this pull request
Dec 7, 2016
dgolitsyn
pushed a commit
to metamx/druid
that referenced
this pull request
Feb 14, 2017
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3683.
Alternate approach to #3684. I think this one makes more sense since it's hitting closer to the heart of the problem: for this case, the output dimension
__timeis a string, so we should configure it that way rather than letting IncrementalIndex default it to long.