remove size from default analysisTypes list for segmentMetadata query #3773
+30
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many external tools (e.g. pivot, caravel etc) use SegmentMetadata query to introspect columns in a dataSource and they do not need the column size. size is slower to compute for string columns and slows down whole query, most people incur that additional cost just because it is included there by default.
Technically, it is backward incompatible so I am willing to move its milestone to 0.10.0 as well.