Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long/float ColumnSelectorStrategy implementations #3838

Merged
merged 23 commits into from
Feb 9, 2017
Merged

Add long/float ColumnSelectorStrategy implementations #3838

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b67e83e
Add long/float ColumnSelectorStrategy implementations
jon-wei Jan 11, 2017
95e2e50
Address PR comments
jon-wei Jan 23, 2017
b783bb8
Merge master
jon-wei Jan 25, 2017
b5fa6c4
Add String strategy with internal dictionary to V2 groupby, remove di…
jon-wei Jan 26, 2017
81d7c73
PR comments
jon-wei Jan 26, 2017
3a3be44
Merge master
jon-wei Jan 27, 2017
c1c1756
Use BaseSingleValueDimensionSelector for long/float wrapping
jon-wei Jan 27, 2017
d5836c1
remove unused import
jon-wei Jan 27, 2017
4633025
Address PR comments
jon-wei Feb 1, 2017
07dc601
PR comments
jon-wei Feb 1, 2017
e529570
PR comments
jon-wei Feb 2, 2017
3fb908e
More PR comments
jon-wei Feb 3, 2017
d6f6384
Fix failing calcite histogram subquery tests
jon-wei Feb 7, 2017
f0c3f5b
ScanQuery test and comment about isInputRaw
jon-wei Feb 7, 2017
b5aef87
Add outputType to extractionDimensionSpec, tweak SQL tests
jon-wei Feb 7, 2017
e5bca4a
Fix limit spec optimization for numerics
jon-wei Feb 7, 2017
299e13f
Add cardinality sanity checks to TopN
jon-wei Feb 7, 2017
ab813bc
Merge remote-tracking branch 'upstream/master' into dimtype3
jon-wei Feb 7, 2017
3e0ff60
Fix import from merge
jon-wei Feb 7, 2017
5b5f385
Add tests for filtered dimension spec outputType
jon-wei Feb 7, 2017
b5dad54
Address PR comments
jon-wei Feb 7, 2017
3e993ee
Allow filtered dimspecs on numerics
jon-wei Feb 8, 2017
bfd6c8c
More comments
jon-wei Feb 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions benchmarks/src/main/java/io/druid/benchmark/DimensionPredicateFilterBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import io.druid.collections.bitmap.RoaringBitmapFactory;
import io.druid.collections.spatial.ImmutableRTree;
import io.druid.query.filter.BitmapIndexSelector;
import io.druid.query.filter.DruidFloatPredicate;
import io.druid.query.filter.DruidLongPredicate;
import io.druid.query.filter.DruidPredicateFactory;
import io.druid.segment.column.BitmapIndex;
Expand Down Expand Up @@ -86,14 +87,13 @@ public boolean apply(String input)
@Override
public DruidLongPredicate makeLongPredicate()
{
return new DruidLongPredicate()
{
@Override
public boolean applyLong(long input)
{
return false;
}
};
return DruidLongPredicate.ALWAYS_FALSE;
}

@Override
public DruidFloatPredicate makeFloatPredicate()
{
return DruidFloatPredicate.ALWAYS_FALSE;
}
},
null
Expand Down
16 changes: 8 additions & 8 deletions benchmarks/src/main/java/io/druid/benchmark/FilterPartitionBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import io.druid.query.filter.BitmapIndexSelector;
import io.druid.query.filter.BoundDimFilter;
import io.druid.query.filter.DimFilter;
import io.druid.query.filter.DruidFloatPredicate;
import io.druid.query.filter.DruidLongPredicate;
import io.druid.query.filter.DruidPredicateFactory;
import io.druid.query.filter.Filter;
Expand Down Expand Up @@ -626,14 +627,13 @@ public boolean apply(String input)
@Override
public DruidLongPredicate makeLongPredicate()
{
return new DruidLongPredicate()
{
@Override
public boolean applyLong(long input)
{
return false;
}
};
return DruidLongPredicate.ALWAYS_FALSE;
}

@Override
public DruidFloatPredicate makeFloatPredicate()
{
return DruidFloatPredicate.ALWAYS_FALSE;
}
};

Expand Down
Loading