Remove LogLevelAdjuster from GuiceRunnable #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drcrallen
commented
May 1, 2017
drcrallen
commented
- Redundant since log4j2 allows config on the fly via jmx
- Fix io.druid.initialization.LogLevelAdjuster uses log4j directly #1805
* Redundant since log4j2 allows config on the fly via jmx * Fix apache#1805
|
@drcrallen what is the incompatible thing about this? |
|
It exposed an mbean as a way of configuring log level. It was an undocumented "api" so is probably ok to remove, but if anyone happened to use the mbean it can screw up their operations stuff. |
|
I think it'd be fine to pull it back to 0.10.1 if you want, undocumented APIs are undocumented so we don't have to worry about compatibility. Up to you though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.