Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KafkaLookupExtractorFactoryTest fast #4466

Merged
merged 3 commits into from
Jun 26, 2017
Merged

Make KafkaLookupExtractorFactoryTest fast #4466

merged 3 commits into from
Jun 26, 2017

Conversation

jihoonson
Copy link
Contributor

@jihoonson jihoonson commented Jun 24, 2017 •
edited
Loading

Fix #4402 (comment).

This change is Reviewable

@jihoonson jihoonson closed this Jun 24, 2017
@jihoonson jihoonson reopened this Jun 24, 2017
leventov
leventov reviewed Jun 24, 2017
View reviewed changes
...xtraction-namespace/src/test/java/io/druid/query/lookup/KafkaLookupExtractorFactoryTest.java Outdated
@@ -562,4 +556,31 @@ public Boolean answer() throws Throwable
}
};
}

private static class ByteArray
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Bytes.asList()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jihoonson jihoonson closed this Jun 25, 2017
@jihoonson jihoonson reopened this Jun 25, 2017
@jihoonson jihoonson closed this Jun 26, 2017
@jihoonson jihoonson reopened this Jun 26, 2017
@jihoonson jihoonson closed this Jun 26, 2017
@jihoonson jihoonson reopened this Jun 26, 2017
@kaijianding kaijianding mentioned this pull request Jun 26, 2017
Closed
pjain1
pjain1 approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@pjain1 pjain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leventov leventov merged commit 5fec619 into apache:master Jun 26, 2017
jon-wei pushed a commit to jon-wei/druid that referenced this pull request Jul 19, 2017
@jihoonson @jon-wei
Make KafkaLookupExtractorFactoryTest fast (apache#4466)
4ced4e7 
* Make KafkaLookupExtractorFactoryTest fast

* Use list

* Use Bytes
@jon-wei jon-wei mentioned this pull request Jul 19, 2017
Closed
@jon-wei jon-wei added this to the 0.10.1 milestone Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventov leventov leventov left review comments

@pjain1 pjain1 pjain1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jihoonson @leventov @pjain1 @jon-wei