Split travis jobs for parallel test #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventov
reviewed
Jun 26, 2017
| - sudo: required | ||
| services: | ||
| - docker | ||
| env: | ||
| - DOCKER_IP=172.17.0.1 | ||
| install: | ||
| # Only errors will be shown with the -q option. This is to avoid generating too many logs which make travis build failed. | ||
| - mvn clean install -q -ff -DskipTests -B | ||
| - mvn install -q -ff -DskipTests -B |
There was a problem hiding this comment.
Every build on travis initializes the project directory by cloning druid's git repository, and thus there will be nothing to be cleaned here.
leventov
approved these changes
Jun 27, 2017
|
@jihoonson thanks 👍 |
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Jul 19, 2017
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Jul 19, 2017
commit 11f2eaa Author: dmitry.golitsyn <[email protected]> Date: Tue Jun 27 21:15:42 2017 +0300 Replace putIfAbsent with computeIfAbsent in DruidBalancer commit 574587b Author: dmitry.golitsyn <[email protected]> Date: Tue Jun 27 16:01:25 2017 +0300 Do not remove segment that should not be moved from currentlyMovingSegments (segments are removed by callbacks or not inserted) commit 7a261c8 Author: Jihoon Son <[email protected]> Date: Tue Jun 27 10:51:48 2017 +0900 Split travis test (apache#4468) commit 05d5868 Author: Roman Leventov <[email protected]> Date: Mon Jun 26 15:21:39 2017 -0500 Remove the ability to create segments in v8 format (apache#4420) * Remove ability to create segments in v8 format * Fix IndexGeneratorJobTest * Fix parameterized test name in IndexMergerTest * Remove extra legacy merging stuff * Remove legacy serializer builders * Remove ConciseBitmapIndexMergerTest and RoaringBitmapIndexMergerTest Do not remove segment that should not be moved from currentlyMovingSegments (segments are removed by callbacks or not inserted) Replace putIfAbsent with computeIfAbsent in DruidBalancer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4402.
This patch further splits the travis test into 4 jobs each of which is for running strict compilation, processing module tests, non-processing modules test, and integration tests, respectively. Tests for processing module takes about 10 mins on travis which is about 25% of the total testing time. Strict compilation also takes more than 5 mins on travis.
With this patch, we cannot exploit the advantage of fail fast strategy, but our tests will be safer.
This change is