Upgrade to server-metrics 0.5.0 #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventov
changed the title
drcrallen
reviewed
Jul 25, 2017
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.metamx</groupId> | ||
| <artifactId>java-util</artifactId> |
There was a problem hiding this comment.
Do we no longer need to exclude java-util?
There was a problem hiding this comment.
@drcrallen Druid doesn't depend on java-util directly. Most if not all deps which depend on it transitively use java-util:0.28.2, including server-metrics.
drcrallen
approved these changes
Jul 25, 2017
|
@leventov After this change, we're hitting a ClassNotFoundException: org.hyperic.jni.ArchNotSupportedException exception from the JvmMonitor class. It seems that in server-metrics 0.5.0, JvmMonitor has a dependency on Sigar which is not pulled into Druid because of the optional dependency. |
|
@a2l007 metamx/server-metrics#33 can you peek at that one? it should fix the problem. |
|
@drcrallen once the server-metrics dependency is updated in Druid, it should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4083
The incompatible difference is explained here: https://github.com/metamx/server-metrics/releases/tag/server-metrics-0.3.0,
jvm/gc/cpuis emitted instead ofjvm/gc/time.jvm/gc/timedidn't actually reflect "GC time" in any reasonable sense. The newjvm/gc/cpuis the amount of CPU time spend in all GC threads in the JVM, measured in nanoseconds.