Remove QueryRunner.run(Query, responseContext) and related legacy methods #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -197,7 +199,8 @@ public void tearDown() throws Exception | |||
| @OutputTimeUnit(TimeUnit.MILLISECONDS) | |||
| public void queryNative(Blackhole blackhole) throws Exception | |||
| { | |||
| final Sequence<Row> resultSequence = groupByQuery.run(walker, Maps.<String, Object>newHashMap()); | |||
| HashMap<String, Object> context = Maps.newHashMap(); | |||
There was a problem hiding this comment.
Could we remove this local var?
| Iterable<Row> results = Sequences.toList(mergedRunner.run(allGranQuery, context), Lists.<Row>newArrayList()); | ||
| Iterable<Row> results = Sequences.toList( | ||
| mergedRunner.run(QueryPlus.wrap(allGranQuery), context), | ||
| new ArrayList<Row>() |
There was a problem hiding this comment.
Could we leave Lists.<Row>newArrayList() ?
There was a problem hiding this comment.
There is no official preference. I suggested to standardize on new ArrayList<>() form before, but it was not supported: #3676 (comment)
egor-ryashin
approved these changes
Jul 27, 2017
jihoonson
approved these changes
Aug 10, 2017
|
@jihoonson thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4324. Adds
Query.getRunner(walker, responseContext)method.